8000 Merge multiple isinstance() calls to one by PatrickCai · Pull Request #6513 · encode/django-rest-framework · GitHub
[go: up one dir, main page]
Skip to content

Merge multiple isinstance() calls to one #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2019
Merged

Merge multiple isinstance() calls to one #6513

merged 2 commits into from
Mar 22, 2019

Conversation

PatrickCai
Copy link
Contributor

See https://docs.python.org/3/library/functions.html#isinstance

If classinfo is a tuple of type objects (or recursively, other such
tuples), return true if object is an instance of any of the type

tomchristie
tomchristie reviewed Mar 19, 2019
View reviewed changes
tomchristie
tomchristie reviewed Mar 19, 2019
View reviewed changes
@tomchristie
Copy link
Member

Yup - absolutely!
Coupla syntax errors to resolve first, but otherwise yes please.

@carltongibson
Copy link
Collaborator

Refs #6481.

@PatrickCai
Fix ) mismatch
f28a383 
Fix `)` mismatch
@PatrickCai
Copy link
Contributor Author

@tomchristie I am wondering is there anything else I should do before it being merged?

@tomchristie tomchristie merged commit b25d245 into encode:master Mar 22, 2019
@tomchristie
Copy link
Member

I am wondering is there anything else I should do before it being merged?

Nothing else, no. 😀
Thanks!

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@PatrickCai
Merge multiple isinstance() calls to one (encode#6513)
422ca03 
* Merge multiple isinstance() calls to one

See https://docs.python.org/3/library/functions.html#isinstance

* Fix `)` mismatch

Fix `)` mismatch
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@PatrickCai @sigvef
Merge multiple isinstan 7277 ce() calls to one (encode#6513)
8070e68 
* Merge multiple isinstance() calls to one

See https://docs.python.org/3/library/functions.html#isinstance

* Fix `)` mismatch

Fix `)` mismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickCai @tomchristie @carltongibson
0