8000 Merge multiple isinstance() calls to one (#6513) · encode/django-rest-framework@b25d245 · GitHub
[go: up one dir, main page]

Skip to content

Commit b25d245

Browse files
PatrickCaitomchristie
authored andcommitted
Merge multiple isinstance() calls to one (#6513)
* Merge multiple isinstance() calls to one See https://docs.python.org/3/library/functions.html#isinstance * Fix `)` mismatch Fix `)` mismatch
1 parent d2d1888 commit b25d245

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

rest_framework/utils/field_mapping.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ def get_field_kwargs(field_name, model_field):
106106
if model_field.null and not isinstance(model_field, models.NullBooleanField):
107107
kwargs['allow_null'] = True
108108

109-
if model_field.blank and (isinstance(model_field, models.CharField) or
110-
isinstance(model_field, models.TextField)):
109+
if model_field.blank and (isinstance(model_field, (models.CharField, models.TextField))):
111110
kwargs['allow_blank'] = True
112111

113112
if isinstance(model_field, models.FilePathField):
@@ -193,9 +192,7 @@ def get_field_kwargs(field_name, model_field):
193192
# Ensure that max_length is passed explicitly as a keyword arg,
194193
# rather than as a validator.
195194
max_length = getattr(model_field, 'max_length', None)
196-
if max_length is not None and (isinstance(model_field, models.CharField) or
197-
isinstance(model_field, models.TextField) or
198-
isinstance(model_field, models.FileField)):
195+
if max_length is not None and (isinstance(model_field, (models.CharField, models.TextField, models.FileField))):
199196
kwargs['max_length'] = max_length
200197
validator_kwarg = [
201198
validator for validator in validator_kwarg

0 commit comments

Comments
 (0)
0