feat: Add getAccentColor on Linux (#48027)
#49531
Open
+65
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Implement `getAccentColor` on Linux * doc: Update OS support for accent color APIs
5 tasks
Member
|
The original PR mentions that a Chromium patch is necessary for it to work. I don't see the patch here. Do you know more about this? |
Member
Author
Good question, it looks like the changes from said upstreamed patch were first included in Chromium version 141.0.7352.0, so the original patch would have to be included here as well to get the full feature in 38-x-y. Given that the preference was to have it be upstreamed for the original PR, I'm curious to hear if people's opinions are different for the backports seeing as both 37-x-y and 38-x-y were requested at the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48027
See that PR for details.
Notes: Added the ability to retrieve the system accent color on Linux using
systemPreferences.getAccentColor.