8000 feat: Add `getAccentColor` on Linux by tautropfli · Pull Request #48027 · electron/electron · GitHub
[go: up one dir, main page]
Skip to content

feat: Add getAccentColor on Linux #48027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 2 commits into from
Oct 21, 2025
Merged

feat: Add getAccentColor on Linux #48027

jkleinsc merged 2 commits into from
Oct 21, 2025

Conversation

@tautropfli
Copy link
Contributor
@tautropfli tautropfli commented Aug 10, 2025 •
edited
Loading

Marked as draft for now since my upstream change has not yet been reviewed/approved.

The included patch has been merged upstream in Chromium.

Description of Change

Checklist

Release Notes

Notes: Added the ability to retrieve the system accent color on Linux using systemPreferences.getAccentColor.

@welcome
Copy link
welcome bot commented Aug 10, 2025

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 10, 2025
@tautropfli tautropfli marked this pull request as ready for review August 13, 2025 14:36
@tautropfli tautropfli requested a review from a team as a code owner August 13, 2025 14:36
@codebytere codebytere self-requested a review August 13, 2025 20:25
@codebytere codebytere added semver/minor backwards-compatible functionality api-review/requested 🗳 labels Aug 19, 2025
codebytere
codebytere requested changes Aug 19, 2025
View reviewed changes
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The added patch here should land in the next Chromium roll that's already open, so we can shrink this PR a bit by rebasing once that lands.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 20, 2025
reitowo
reitowo reviewed Aug 25, 2025
View reviewed changes
codebytere
codebytere reviewed Aug 28, 2025
View reviewed changes
reitowo
reitowo reviewed Aug 28, 2025
View reviewed changes
erickzhao
erickzhao reviewed Aug 28, 2025
View reviewed changes
reitowo
reitowo approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member
@reitowo reitowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

erickzhao
erickzhao approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member
@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@tautropfli
Copy link
Contributor Author
tautropfli commented Aug 29, 2025

Wohoo 🚀

@tautropfli tautropfli requested a review from codebytere August 30, 2025 09:21
@tautropfli
Copy link
Contributor Author
tautropfli commented Aug 30, 2025

The macOS CI failure is unrelated to my changes, right?

@codebytere
Copy link
Member
codebytere commented Oct 8, 2025

@bash sorry for delay - could you please rebase this?

codebytere
codebytere approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@tautropfli
Copy link
Contributor Author
tautropfli commented Oct 8, 2025

@codebytere Rebased ✨

@codebytere codebytere added target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 8, 2025
@jkleinsc jkleinsc merged commit 7ec0ebc into electron:main Oct 21, 2025
160 of 162 checks passed
@welcome
Copy link
welcome bot commented Oct 21, 2025

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link
release-clerk bot commented Oct 21, 2025

Release Notes Persisted

Added the ability to retrieve the system accent color on Linux using systemPreferences.getAccentColor.

@trop
Copy link
Contributor
trop bot commented Oct 21, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor
trop bot commented Oct 21, 2025

I was unable to backport this PR to "38-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y needs-manual-bp/38-x-y and removed target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Oct 21, 2025
@trop trop bot mentioned this pull request Oct 21, 2025
Merged
@trop
Copy link
Contributor
trop bot commented Oct 21, 2025

I have automatically backported this PR to "39-x-y", please check out #48628

@trop trop bot added in-flight/39-x-y and removed target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 21, 2025
@tautropfli tautropfli deleted the accent-color-linux branch October 21, 2025 18:42
@trop trop bot added merged/39-x-y PR was merged to the "39-x-y" branch. and removed in-flight/39-x-y labels Oct 23, 2025
TheCommieAxolotl pushed a commit to TheCommieAxolotl/electron that referenced this pull request Nov 2, 2025
@tautropfli @TheCommieAxolotl
feat: Add getAccentColor on Linux (electron#48027)
4715027 
* feat: Implement `getAccentColor` on Linux

* doc: Update OS support for accent color APIs
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@tautropfli
feat: Add getAccentColor on Linux (electron#48027)
88fbfdc 
* feat: Implement `getAccentColor` on Linux

* doc: Update OS support for accent color APIs
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
feat: Add getAccentColor on Linux (electron#48027)
02b5e59 
* feat: Implement `getAccentColor` on Linux

* doc: Update OS support for accent color APIs
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya
feat: Add getAccentColor on Linux (electron#48027)
45added 
* feat: Implement `getAccentColor` on Linux

* doc: Update OS support for accent color APIs
mlaurencin pushed a commit that referenced this pull request Jan 26, 2026
@tautropfli @mlaurencin
feat: Add getAccentColor on Linux (#48027)
ed83ccb 
* feat: Implement `getAccentColor` on Linux

* doc: Update OS support for accent color APIs
@mlaurencin mlaurencin mentioned this pull request Jan 26, 2026
Closed
@trop
Copy link
Contributor
trop bot commented Jan 26, 2026

@mlaurencin has manually backported this PR to "38-x-y", please check out #49531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

+2 more reviewers

@erickzhao erickzhao erickzhao approved these changes

@reitowo reitowo reitowo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-review/approved ✅ merged/39-x-y PR was merged to the "39-x-y" branch. needs-manual-bp/37-x-y semver/minor backwards-compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: systemPreferences.getAccentColor Linux support

5 participants

@tautropfli @codebytere @jkleinsc @erickzhao @reitowo
0