adding pre-stuff for parsing Pascal files #11438

paule32 · 2025-02-19T19:17:45Z

I have add pre-stuff for parsing Pascal files, later.
This branch stuff is only for testing, and for learning how doxygen works.

I have implement the missing Translator functions for geman users (translator_de.h)

stay tuned
next coming soon...

Line: 1787 - change **el** to **RENAMED_el** as workaround for a CHM Link produce Problem. When RENAMED_ is not available, doxygen tends to produce double qoutes for a Link

pre-adding stuff for parse pascal files this is only a testing branch !!!

albert-github

Some comments might sound a bit harsh or bitchy but are not intended as such, they are just as guide. Changes are always welcome.

src/dbcode.h

albert-github · 2025-02-20T12:54:15Z

src/dbcode.h

+/*  This code is based on the work done by the MoxyPyDoxy team
+ *  (Linda Leong, Mike Rivera, Kim Truong, and Gabriel Estrada)
+ *  in Spring 2005 as part of CS 179E: Compiler Design Project
+ *  at the University of California, Riverside; the course was
+ *  taught by Peter H. Froehlich <phf@acm.org>.
+ */


Remainder of copy paste

I will copy in it

I assume you mean remove.

albert-github · 2025-02-20T12:57:01Z

src/dbcode.l

+#define YY_NO_INPUT 1
+#define YY_NO_UNISTD_H 1
+
+struct dbcodeYY_state


Work in progress so number of variables wil probably change later on

should I rename db to dBase
So dBasecodeYY_state
???

The remark more a general remark that the elements in the state variable will most likely change in the future.
I think though that you are right that it is better to use dBasecodeYY_state instead of dbcodeYY_state.

albert-github · 2025-02-20T12:59:08Z

src/doxygen.cpp

+                    lang     == SrcLangExt::Python        ||
+                    lang     == SrcLangExt::Java          ||
+                    lang     == SrcLangExt::PHP           ||
+


Why extra empty line?

for better reading.
I can revert the changes if you prefer.
I have a affine style of code that contain readable variables with spaces...

I have note your comment, and will revert the coding style

albert-github · 2025-02-20T13:03:19Z

src/htmldocvisitor.cpp

@@ -401,8 +401,7 @@ void HtmlDocVisitor::operator()(const DocURL &u)
  else // web address
  {
    m_t << "<a href=\"";
-    filter(u.url());
-    m_t << "\">";
+    m_t << u.url() << "\">";


Looks to me an incorrect change by accident / not merged properly with master. The filter was explicitly added for #11404 to be reverted.

albert-github · 2025-02-20T13:06:10Z

src/htmlgen.cpp

@@ -3475,7 +3475,7 @@ void HtmlGenerator::writeInheritedSectionTitle(
  DBG_HTML(m_t << "<!-- writeInheritedSectionTitle -->\n";)
  QCString a = anchor;
  if (!a.isEmpty()) a.prepend("#");
-  QCString classLink = QCString("<a class=\"el\" ");
+  QCString classLink = QCString("<a class=\"RENAMED4_el\" ");


Probably based on some old and incorrect changes for some other issues you had, to be reverted

yes, for debug sessions on my side, I am sorry for this
I note it, and will revert the changes.

albert-github · 2025-02-20T13:06:29Z

src/pascode.h

+/*  This code is based on the work done by the MoxyPyDoxy team
+ *  (Linda Leong, Mike Rivera, Kim Truong, and Gabriel Estrada)
+ *  in Spring 2005 as part of CS 179E: Compiler Design Project
+ *  at the University of California, Riverside; the course was
+ *  taught by Peter H. Froehlich <phf@acm.org>.
+ */


albert-github · 2025-02-20T13:12:23Z

src/translator_adapter.h

+class TranslatorAdapter_1_13_0 : public TranslatorAdapterBase
+{
+  public:
+    QCString updateNeededMessage() override
+    { return createUpdateNeededMessage(idLanguage(),"release 1.13.0"); }
+    QCString trImportant() override
+    { return english.trImportant(); }
+};
+


Changes for translations are very welcome.
Changes for the translation are not related to the pascal / dbase implementation and have to be handled in a separate PR. (No PR hijacking)

Furthermore there is no need for adding a 1_13_0 translator adapter, when updating to the current version (which is anyway 1.13.2) in the translator file the base class Translator should be used.

albert-github · 2025-02-20T13:12:34Z

src/translator_de.h

@@ -140,13 +140,16 @@
 //   2024/05/03 Jens Kallup (kallup-dev@web.de)
 //    - Updated for 1.10.0
 //
+//   2025/02/19 Jens Kallup (kallup-dev@web.de)
+//    - Updated for 1.13.0


Should be 1.13.2

Furthermore the changes in this file should be in a separate PR as note already in the translator_adapter.h

I note this and will make the changes you wish.

albert-github · 2025-02-20T13:12:56Z

src/translator_de.h

 //   Todo:
 //    - see FIXME

 #ifndef TRANSLATOR_DE_H
 #define TRANSLATOR_DE_H

-class TranslatorGerman : public TranslatorAdapter_1_8_15
+class TranslatorGerman : public TranslatorAdapter_1_13_0


Should be to Translator

I note this, and I will revert the changes.

albert-github · 2025-02-20T13:37:59Z

As the PR is work in progress I set it to work in progress / draft.

To have a look why the GitHub Actions failed I restarted 1 run and saw the new warnings:

/home/runner/work/doxygen/doxygen/src/docsets.cpp: In member function ‘virtual void DocSets::addIndexItem(const Definition*, const MemberDef*, const QCString&, const QCString&)’:
/home/runner/work/doxygen/doxygen/src/docsets.cpp:304:10: warning: enumeration value ‘Pascal’ not handled in switch [-Wswitch]
  304 |   switch (langExt)
      |          ^
/home/runner/work/doxygen/doxygen/src/docsets.cpp:304:10: warning: enumeration value ‘dBase’ not handled in switch [-Wswitch]

these should be handled. The other warnings (as far as I can see are known and expected and "OK").

The problem regarding the documentation generation is persistent and probably caused by the incorrect usage of TranslatorAdapter as already noted in the review.

I have change the project date at some files. I have start a parser project, that shall parse pascal source code. I revert code that was misswriten by me (debug sessions) I have add the re-mark comment in the scanner.l and code.l files The pascal parser is in pre-alpha-mode, so no productive, yet. I have complete implemented the missing references of translation part - see translateor_de. So, stay tunded...

…vate

albert-github · 2025-02-21T08:56:14Z

Looks like again some changes got in undoing recent fixes in the doxygen master version (e.g. deps/libmscgen/mscgen_config.h)
To update to master you should use the merge functionality of git.

paule32 · 2025-02-21T15:10:24Z

with upload the new file(s) docsets.cpp and passcanner.l, I fixed the issue in docsets.cpp.
I use a exit(1); C-function, to stop doxygen with processing in file passcanner.l
So, you can parse Pascal files (mapper file extensions: *.pas and *.pp).

In real, this is beta ware. Because only the recognition the extensions to set the config on. works.
And a second reason for this is, that I don't parse Pascal files in detail, yet.

But you can parse (* *) comments, whitespaces and a line like this: **unit test ; **.
In the other files, I have update the dates to 1997-2025.

More will come soon...

this is the initial commit for the german translation it is still in progress and valued as test only

github.com had changed the artefacts build version from v3 to v4. so, workflow run don't start.

remove typos

I have start the modularization of Doxygen by implement GNU gettext that you can use in combination with .mo files. mo files are compiled/indexed localization files that can be used to provide different languages for the application with one source code texts.

albert-github · 2025-02-23T11:49:42Z

In my previous comments I mentioned some things about how to proceed (a.o.) and it is better to address these issues first

concentrate on one parser e.g. pascalscanner and pascalcode or sbasescanner / dbasecode and get this properly up and running
don't mix different functionality (trandlator_de) should be in its own proposed pull request.
changes to yml should not be necessary, the add new yml files look like functionality for one user and are probably of no interest to the CI system and when of interest they should be in a separate proposed pull request
a proper merge with the master branch should be mad so no reverts of code necessary in master will be present (like now for the files from doc_internal).

fixed Windows 10 64-Bit support typo

…vate

This workflow provides a compile run for Microsoft Visual Studio 17 (2022). It is more for testing and providing Windows 10 64-Bit based doxygen files with all needed *.dll *.mo and *.exe files. *.mo files are compiled localization files for your System Language / User preferenced Language and Region Settings. They are pre-built in the artefacts of this workflow. You can download the provided zip packed archive.

paule32 · 2025-02-24T17:11:49Z

.github/workflows/windows_cmake.yml

This is doxygen for Windows

I don't see what this has to do with the pascal implementation or what the usage / intention for the doxygen GitHub Actions could be.

See also my earlier comments in #11438 (comment)

Indeed, don't mix different features in one pull request if you ever wish to have it merged.

doxygen · 2025-02-24T19:10:26Z

LICENSE

-consider it more useful to permit linking proprietary applications with the
-library.  If this is what you want to do, use the GNU Lesser General
-Public License instead of this License.
+MIT License


I don't know what the idea is here, but you cannot change the license.

sorry for this - during creation a copy of doxygen, github.com ask me for a license.
I must be carefully go on the work in the future.
Also, sorry for this.

btw: you mentioned License's:

I have start modularize doxygen by splitting data and code

I have create GNU gettext libraries for Windows 64-Bit port with nmake from Visual Studio 17 (2022)

currently, I have add binary *.mo files (see: msgfmt tool):

Dutch,

English, and

German

currently we only need one platform for creating these files (I have preferenced Ubuntu Linus Toolchain)

because the files are binary compatible under Windows and Linux

for the MacOS platform, I have not found a solution, because I don't own my own Macintosh Computer and I don't know if MacOS amd64/ia64 compatible, and I would not get into illegal keys in no subways.

You can take a look to the new workflow file windows.yml at: here
You can take a look to the localization repro, that I involved in windows_cmake.yml file: here

I don't want to have doxygen to depend on gettext. It is not very portable.

but it is the simplest and re-commend in my eyes for:

fixing spell errors

adding new languages

change the lang context during the doxygen application run

In other project's, I have use gettext and gzip versions (for shrink the storage usage - not all languages are needed for the same time. And it is a very handy process to de-compress lang files and use in doxygen.

I am a happy developer that does provide and adviced each one othets to use modularization of the developers application.

The times where C++Builder 1.0 hold all resources into one files are out of date.
Today, the executable file is splitted into DATA and CODE.
This makes the application flexible - in view of changed versions of jquery, too.

overlaped License dont aply with doxygen original License, so I have delete the automatic created License. I am excuse me for this - because I run into trouble with the Desktop Application to handle github repros.

doxygen · 2025-02-24T19:57:27Z

templates/html/search_functions.php

@@ -1,6 +1,20 @@
 <?php
 require_once "search_config.php";

+function end_form($value)


I removed this recently. Seems like your merge strategy is wrong and adds back removed code!

I don't remember me,. that I had change this php file

paule32 added 2 commits February 16, 2025 00:38

Update htmlgen.cpp

27e0ba3

Line: 1787 - change **el** to **RENAMED_el** as workaround for a CHM Link produce Problem. When RENAMED_ is not available, doxygen tends to produce double qoutes for a Link

update paule32 Pascal parser

0aa5af9

pre-adding stuff for parse pascal files this is only a testing branch !!!

albert-github reviewed Feb 20, 2025

View reviewed changes

albert-github marked this pull request as draft February 20, 2025 13:35

paule32 and others added 6 commits February 20, 2025 19:45

Update build_cmake.yml

333fb1b

Merge branch 'doxygen:master' into private

7129282

Merge branch 'doxygen:master' into private

7e3a35c

Merge branch 'private' of https://github.com/paule32/doxygen into pri…

47366d2

…vate

update translator and pascal parser

dcc6f6f

paule32 marked this pull request as ready for review February 21, 2025 06:26

albert-github marked this pull request as draft February 21, 2025 12:26

update file docsets.cpp and passcanner.l

bbeb386

paule32 marked this pull request as ready for review February 21, 2025 15:10

paule32 added 13 commits February 22, 2025 10:12

update locales de translation

a995378

create initial translation.yml

37261a8

this is the initial commit for the german translation it is still in progress and valued as test only

update locale english

767a067

Update translation.yml

9c798b6

Update translation.yml

acbb508

Update translation.yml

c772964

github.com had changed the artefacts build version from v3 to v4. so, workflow run don't start.

Update translation.yml

d3c21b2

remove typos

Update build_cmake.yml

229cd21

Update build_cmake.yml

db9c8f8

Update build_cmake.yml

cc537b5

Update build_cmake.yml

8c80bab

Update build_cmake.yml

dca37f7

Update build_cmake.yml

9b642a2

paule32 added 18 commits February 23, 2025 12:57

Update CMakeLists.txt

f1dc664

fixed Windows 10 64-Bit support typo

Update build_cmake.yml

c8dbb58

Update CMakeLists.txt

85a24d7

Update build_cmake.yml

a5e3869

Update build_cmake.yml

8fb0f74

Update build_cmake.yml

c89780e

Update build_cmake.yml

e7a2c19

Update build_cmake.yml

8e19f84

Update CMakeLists.txt

936e68f

update

37ac297

Merge branch 'private' of https://github.com/paule32/doxygen into pri…

6310509

…vate

Update CMakeLists.txt

2bdd3ba

update

7f3866d

Merge branch 'private' of https://github.com/paule32/doxygen into pri…

5ae455e

…vate

Update and rename build_cmake.yml to windows_cmake.yml

568ccc7

Update windows_cmake.yml

a80f153

Update windows_cmake.yml

da2debe

paule32 commented Feb 24, 2025

View reviewed changes

Delete .github/workflows/translate.yml

69a0cf7

doxygen reviewed Feb 24, 2025

View reviewed changes

paule32 and others added 5 commits February 24, 2025 20:30

add Dutch License translation

2e881f3

Update windows_cmake.yml

9182d8b

Merge branch 'doxygen:master' into private

3504c1c

Delete LICENSE

7b1a09c

overlaped License dont aply with doxygen original License, so I have delete the automatic created License. I am excuse me for this - because I run into trouble with the Desktop Application to handle github repros.

Merge branch 'doxygen:master' into private

1717e79

update

ee96838

adding pre-stuff for parsing Pascal files #11438

Are you sure you want to change the base?

adding pre-stuff for parsing Pascal files #11438

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!