Incorrect field when ampersand in URL #11404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having an ampersand in an URL like: ``` https://en.wikipedia.org/w/index.php?title=Unsharp_masking&oldid=750486803#Photographic_unsharp_masking ``` this can lead to a warning in the xmllint checker like: ``` html\md_aa.html:108: parser error : EntityRef: expecting ';' ck"><p><a href="https://en.wikipedia.org/w/index.php?title=Unsharp_masking&oldid ^ ``` Note in e.g. the xml and docbook format there were already twice the filter call.
doxygen
reviewed
Feb 10, 2025
| @@ -401,7 +401,8 @@ void HtmlDocVisitor::operator()(const DocURL &u) | |||
| else // web address | |||
| { | |||
| m_t << "<a href=\""; | |||
| m_t << u.url() << "\">"; | |||
| filter(u.url()); | |||
There was a problem hiding this comment.
The url needs URL encoding inside the href and HTML encoding outside, see https://stackoverflow.com/a/1812486/784672. Probably also holds for XML and docbook.
There was a problem hiding this comment.
Looks indeed the case that is required for all formats that potentially use the string to start a HTML browser, so probably not only XML and Docbook but also LaTeX, RTF, ...
There was a problem hiding this comment.
Hmm, I tried URL encoding, but then & is not escaped, so it still doesn't pass XML/XHTML checks. So I think your fix is correct as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having an ampersand in an URL like:
this can lead to a warning in the xmllint checker like:
Note in e.g. the xml and docbook format there were already twice the filter call.
Example: example.tar.gz
(Found in the ITK package)