8000 [StyleCleanUp] Order modifiers on members/types (IDE0036) by h3xds1nz · Pull Request #10601 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

[StyleCleanUp] Order modifiers on members/types (IDE0036) #10601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 3, 2025
Merged

[StyleCleanUp] Order modifiers on members/types (IDE0036) #10601

merged 9 commits into from
Apr 3, 2025

Conversation

h3xds1nz
Copy link
Member
@h3xds1nz h3xds1nz commented Mar 19, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #10354

Description

Orders modifiers to be in-accordance with standard C# coding style. Sending this now when #10021 was merged.

Currently blocks #10382.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 19, 2025 09:47
@h3xds1nz h3xds1nz mentioned this pull request Mar 19, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 19, 2025
@codecov Codecov
Copy link
codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.45455% with 104 lines in your changes missing coverage. Please review.

Project coverage is 10.95917%. Comparing base (9cfcf9e) to head (14d26a3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #10601         +/-   ##
===================================================
+ Coverage   10.90789%   10.95917%   +0.05128%     
===================================================
  Files           3310        3310                 
  Lines         664693      664667         -26     
  Branches       74667       74667                 
===================================================
+ Hits           72504       72842        +338     
+ Misses        591057      590684        -373     
- Partials        1132        1141          +9
Flag Coverage Δ
Debug 10.95917% <5.45455%> (+0.05128%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siagupta0202 siagupta0202 self-assigned this Mar 20, 2025
@siagupta0202
Copy link
Contributor

The PR looks good to me, @h3xds1nz can you resolve the merge conflicts?

@h3xds1nz
Copy link
Member Author
h3xds1nz commented Apr 3, 2025

@siagupta0202 Done :)

@siagupta0202 siagupta0202 merged commit 2ded801 into dotnet:main Apr 3, 2025
8 checks passed
@siagupta0202
Copy link
Contributor

@h3xds1nz Thank you so much for your contribution 😊

@h3xds1nz
Copy link
Member Author
h3xds1nz commented Apr 3, 2025

@siagupta0202 Thank you as well :)

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@siagupta0202 siagupta0202 siagupta0202 approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

@Kuldeep-MS Kuldeep-MS Awaiting requested review from Kuldeep-MS

Assignees

@h3xds1nz h3xds1nz

@siagupta0202 siagupta0202

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE0036: Order modifiers
2 participants
@h3xds1nz @siagupta0202
0