8000 [StyleCleanUp] Add missing accessibility modifiers on members (IDE0040) by h3xds1nz · Pull Request #10021 · dotnet/wpf · GitHub
[go: up one dir, main page]
Skip to content

[StyleCleanUp] Add missing accessibility modifiers on members (IDE0040) #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 19, 2025
Merged

[StyleCleanUp] Add missing accessibility modifiers on members (IDE0040) #10021

merged 9 commits into from
Mar 19, 2025

Conversation

h3xds1nz
Copy link
Member
@h3xds1nz h3xds1nz commented Oct 30, 2024 •
edited
Loading

Fixes #10284
Fixes #10288

Description

Adds missing accessibility modifiers throughout the codebase. All of the edits were done automatically.

Customer Impact

Cleaner codebase.

Regression

No.

Testing

Local build.

Risk

Minimal.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners October 30, 2024 15:04
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Oct 30, 2024
@dipeshmsft
Copy link
Member

@h3xds1nz
all the changes were done automatically as in ?

@h3xds1nz
Copy link
Member Author
h3xds1nz commented Nov 10, 2024 •
edited
Loading

@h3xds1nz all the changes were done automatically as in ?

@dipeshmsft Means I didn't do these by hand, just applied fix per-project.

@h3xds1nz h3xds1nz mentioned this pull request Jan 8, 2025
Closed
@h3xds1nz h3xds1nz force-pushed the xaml-accessibility-modifiers branch from 16c26f2 to 9e27641 Compare January 9, 2025 03:41
@h3xds1nz h3xds1nz changed the title [Cleanup] Add missing accessibility modifiers in System.Xaml (IDE0040) [Cleanup] Add missing accessibility modifiers on members (IDE0040) Jan 9, 2025
@h3xds1nz h3xds1nz force-pushed the xaml-accessibility-modifiers branch from 9e27641 to 28e59e7 Compare January 9, 2025 10:57
@h3xds1nz
Copy link
Member Author
h3xds1nz commented Jan 9, 2025

@harshit7962 Should be all done; I've built it on top of this one, felt easier.

And yeah, solving IDE0040 resolved SA1400 occurrences as well, so I've removed both from .editorconfig.

@h3xds1nz h3xds1nz changed the title [Cleanup] Add missing accessibility modifiers on members (IDE0040) [StyleCleanUp] Add missing accessibility modifiers on members (IDE0040) Jan 15, 2025
@siagupta0202
Copy link
Contributor

@h3xds1nz could you revert the changes in the generated files and instead make those changes in the generator and run that file to see the corresponding changes in the generated files?

@h3xds1nz h3xds1nz force-pushed the xaml-accessibility-modifiers branch from b7196e1 to 5e9a4e3 Compare March 17, 2025 12:53
@h3xds1nz
Copy link
Member Author

@siagupta0202 Done but with a workaround as one generated resource is internal and I don't really want to go now and add accessibility modifiers feature because of 1 single resource that was made internal while rest is public.

@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.66667% with 149 lines in your changes missing coverage. Please review.

Project coverage is 11.56123%. Comparing base (1472dd5) to head (5e9a4e3).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #10021         +/-   ##
===================================================
+ Coverage   11.55663%   11.56123%   +0.00459%     
===================================================
  Files           3214        3214                 
  Lines         648502      648452         -50     
  Branches       71510       71510                 
===================================================
+ Hits           74945       74969         +24     
+ Misses        572396      572226        -170     
- Partials        1161        1257         +96
Flag Coverage Δ
Debug 11.45757% <0.66667%> (+0.00459%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siagupta0202
Copy link
Contributor

LGTM

@siagupta0202 siagupta0202 merged commit b360342 into dotnet:main Mar 19, 2025
8 checks passed
@siagupta0202
Copy link
Contributor

@h3xds1nz Thank you so much for your tremendous help!

@h3xds1nz h3xds1nz mentioned this pull request Mar 19, 2025
Merged
@h3xds1nz
Copy link
Member Author

@siagupta0202 Thank you :) Sent #10601 next to continue the journey.

@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Apr 4, 2025
Merged
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Apr 12, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThomasGoulet73 ThomasGoulet73 ThomasGoulet73 left review comments

@siagupta0202 siagupta0202 siagupta0202 approved these changes

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@h3xds1nz h3xds1nz

@siagupta0202 siagupta0202

Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SA1400: Element should declare an access modifier IDE0040: Add accessibility modifiers
6 participants
@h3xds1nz @dipeshmsft @siagupta0202 @ThomasGoulet73 @harshit7962 @himgoyalmicro
0