-
Notifications
You must be signed in to change notification settings - Fork 1.1k
sln-add: --include-references when adding a project #48815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
471d3f2
sln-add: Add --include-references option
edvilme 69a479a
Add tests
edvilme 38c7840
Check for flag too
edvilme 993c28c
Fix tests
edvilme bd001ce
Address pr comments
edvilme 09abcb9
Udpate cli completions
edvilme 1576ff5
Update tests messages
edvilme 34c0d37
Correctly get referencedprojects
edvilme 266ef2e
Fix tests
edvilme f8e64fe
Add parentheses to condition
edvilme c0b6c3b
Merge branch 'main' into edvilme-sln-add-recursive
edvilme 4b810a5
Address pr comments
edvilme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Address pr comments
- Loading branch information
commit bd001ce1207aae30b1e90d88e5edfca0f7f8e4d2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,14 +204,12 @@ private void AddProject(SolutionModel solution, string fullProjectPath, ISolutio | |
project.AddProjectConfigurationRule(new ConfigurationRule(BuildDimension.BuildType, solutionBuildType, "*", projectBuildType)); | ||
} | ||
|
||
Reporter.Output.WriteLine(CliStrings.ProjectAddedToTheSolution, solutionRelativeProjectPath); | ||
|
||
// Get referencedprojects from the project instance | ||
var referencedProjectsFullPaths = projectInstance.EvaluatedItemElements | ||
edvilme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.Where(item => item.ItemType == "ProjectReference") | ||
.Select(item => item.Include) | ||
.Select(item => Path.GetFullPath(item, Path.GetDirectoryName(fullProjectPath))) | ||
.ToList(); | ||
|
||
Reporter.Output.WriteLine(CliStrings.ProjectAddedToTheSolution, solutionRelativeProjectPath); | ||
.Where(item => item.ItemType.Equals("ProjectReference")) | ||
.Select(item => Path.GetFullPath(item.Include, Path.GetDirectoryName(fullProjectPath))); | ||
|
||
if (_includeReferences) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adding cycle detection or duplicate addition checks when recursively adding referenced projects to prevent potential infinite recursion in cases of cyclic project references. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
{ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider updating the comment to 'Get referenced projects from the project instance' for improved clarity.
Copilot uses AI. Check for mistakes.