8000 sln-add: --include-references when adding a project by edvilme · Pull Request #48815 · dotnet/sdk · GitHub
[go: up one dir, main page]
Skip to content

sln-add: --include-references when adding a project #48815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 9, 2025
Merged

sln-add: --include-references when adding a project #48815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
471d3f2
sln-add: Add --include-references option
edvilme May 2, 2025
69a479a
Add tests
edvilme May 5, 2025
38c7840
Check for flag too
edvilme May 5, 2025
993c28c
Fix tests
edvilme May 5, 2025
bd001ce
Address pr comments
edvilme May 5, 2025
09abcb9
Udpate cli completions
edvilme May 6, 2025
1576ff5
Update tests messages
edvilme May 6, 2025
34c0d37
Correctly get referencedprojects
edvilme May 7, 2025
266ef2e
Fix tests
edvilme May 8, 2025
f8e64fe
Add parentheses to condition
edvilme May 8, 2025
c0b6c3b
Merge branch 'main' into edvilme-sln-add-recursive
edvilme May 9, 2025
4b810a5
Address pr comments
edvilme May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Udpate cli completions
  • Loading branch information
@edvilme
edvilme committed May 6, 2025
commit 09abcb99956aab3f781fd2b0c610d6bc4755bd0b
6 changes: 5 additions & 1 deletion ...Tests/CompletionTests/snapshots/bash/DotnetCliSnapshotTests.VerifyCompletions.verified.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,7 +1421,7 @@ _testhost_solution_add() {
prev="${COMP_WORDS[COMP_CWORD-1]}"
COMPREPLY=()

opts="--in-root --solution-folder --help"
opts="--in-root --solution-folder --include-references --help"

if [[ $COMP_CWORD == "$1" ]]; then
COMPREPLY=( $(compgen -W "$opts" -- "$cur") )
Expand All @@ -1433,6 +1433,10 @@ _testhost_solution_add() {
COMPREPLY=( $(compgen -W "False True" -- "$cur") )
return
;;
--include-references)
COMPREPLY=( $(compgen -W "False True" -- "$cur") )
return
;;
esac

COMPREPLY=( $(compgen -W "$opts" -- "$cur") )
Expand Down
1 change: 1 addition & 0 deletions ...ests/CompletionTests/snapshots/pwsh/DotnetCliSnapshotTests.VerifyCompletions.verified.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,6 +840,7 @@ Register-ArgumentCompleter -Native -CommandName 'testhost' -ScriptBlock {
[CompletionResult]::new('--in-root', '--in-root', [CompletionResultType]::ParameterName, "Place project in root of the solution, rather than creating a solution folder.")
[CompletionResult]::new('--solution-folder', '--solution-folder', [CompletionResultType]::ParameterName, "The destination solution folder path to add the projects to.")
[CompletionResult]::new('--solution-folder', '-s', [CompletionResultType]::ParameterName, "The destination solution folder path to add the projects to.")
[CompletionResult]::new('--include-references', '--include-references', [CompletionResultType]::ParameterName, "Recursively add projects`' ReferencedProjects to solution")
[CompletionResult]::new('--help', '--help', [CompletionResultType]::ParameterName, "Show command line help.")
[CompletionResult]::new('--help', '-h', [CompletionResultType]::ParameterName, "Show command line help.")
)
Expand Down
1 change: 1 addition & 0 deletions ...Tests/CompletionTests/snapshots/zsh/DotnetCliSnapshotTests.VerifyCompletions.verified.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,7 @@ _testhost() {
'--in-root=[Place project in root of the solution, rather than creating a solution folder.]: :((False\:"False" True\:"True" ))' \
'--solution-folder=[The destination solution folder path to add the projects to.]: : ' \
'-s=[The destination solution folder path to add the projects to.]: : ' \
'--include-references=[Recursively add projects'\'' ReferencedProjects to solution]: :((False\:"False" True\:"True" ))' \
'--help[Show command line help.]' \
'-h[Show command line help.]' \
'*::PROJECT_PATH -- The paths to the projects to add to the solution.: ' \
Expand Down
Loading
0