10000 Removed table formatting by gewarren · Pull Request #8 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]

Skip to content

Removed table formatting #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gewarren
Copy link
Contributor
@gewarren gewarren commented Apr 2, 2018

Unnecessary table formatting appears elsewhere in this topic too, but it looks like it might be coming from source code anyway so I didn't want to fix it if it would just be overwritten.

Unnecessary table formatting appears elsewhere in this topic too, but it looks like it might be coming from source code anyway so I didn't want to fix it if it would just be overwritten.
@dnfclas
Copy link
dnfclas commented Apr 2, 2018

CLA assistant check
All CLA requirements met.

@mairaw
Copy link
Contributor
mairaw commented Apr 2, 2018

Our API docs are manually written so they don't get overwritten. I'll take a look at your proposed changes.

@mairaw mairaw mentioned this pull request Apr 4, 2018
Copy link
Contributor
@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren I've created a new PR (#15) to test an alternative fix to this issue. I think this table is used throughout the docs and it might be easier to fix it that way across the entire docset. I think this is still related to the migration done from MSDN.

2. Click the **Application** tab.
3. Click the **View Application Events** button to open the Code Editor.

For more information, see [Application Page, Project Designer (Visual Basic)](https://docs.microsoft.com/visualstudio/ide/reference/application-page-project-designer-visual-basic).|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last pipe should be removed

@mairaw
Copy link
Contributor
mairaw commented Apr 4, 2018

Closing this in favor of PR #15. Thanks @gewarren!

@mairaw mairaw closed this Apr 4, 2018
@gewarren gewarren deleted the patch-1 branch June 25, 2020 18:53
@masoudahg00 masoudahg00 mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0