8000 fix table layout by mairaw · Pull Request #15 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]
Skip to content

fix table layout #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2018
Merged

fix table layout #15

merged 2 commits into from
Apr 5, 2018

Conversation

mairaw
Copy link
Contributor
@mairaw mairaw commented Apr 4, 2018 •
edited
Loading

Test alternative for PR #8

Internal review URL

@mairaw
Copy link
Contributor Author
mairaw commented Apr 4, 2018

It seems this was the only topic with this exact configuration. Other topics have at least two columns and that doesn't happen when you have two columns. e.g. https://docs.microsoft.com/en-us/dotnet/api/microsoft.windows.themes.bulletchrome.background

@mairaw mairaw mentioned this pull request Apr 4, 2018
Closed
@gewarren
Copy link
Contributor
gewarren commented Apr 4, 2018

Interesting, thanks for fixing it!

@mairaw mairaw requested a review from rpetrusha April 4, 2018 17:44
@mairaw mairaw added the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Apr 4, 2018
@mairaw mairaw added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Apr 4, 2018
rpetrusha
rpetrusha approved these changes Apr 4, 2018
View reviewed changes
Copy link
@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @mairaw. There's one nit: I found the placement of the "For more information, see..." line to be confusing -- I think it would benefit from an extra <br/>. But this is ready to merge when you want.

@mairaw mairaw added verify-build-before-merge and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews verify-build-before-merge labels Apr 4, 2018
@mairaw mairaw merged commit 4a0c80b into dotnet:master Apr 5, 2018
@mairaw mairaw deleted the mairaw-patch-2 branch April 5, 2018 00:12
@mairaw mairaw self-assigned this Apr 5, 2018
@masoudahg00 masoudahg00 mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpetrusha rpetrusha rpetrusha approved these changes

Assignees

@mairaw mairaw

Labels
area-Microsoft.VisualBasic
Projects
None yet
Milestone
Sprint 133 (3/17/18 - 4/06/18)
Development

Successfully merging this pull request may close these issues.
4 participants
@mairaw @gewarren @rpetrusha @eiriktsarpalis
0