update sample links #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4442) Rephrase 'not' => 'Neither' + 'nor'
* add two options explanation * fixed heading
* Maximum size of file to be compressed Added information about maximum file size that can be compressed, and exception that is thrown when limit is reached * Respond to feedback * respond to editing feedback. * replace xref syntax with cref syntax * fixed link format * fix links include the type with int.Maxvalue Replace an incorrect cref with xref. * make sure the additions are in both overloads.
Remove unused variable creating confusion: GeometryDrawing myGeometryDrawing = new GeometryDrawing();
* Addressed customer feedback about ControlBox property * Incorporated review comments
* Fixed example Snippet and clarified it. * Renamed "Local" to "LocalFunction" From my previous commit, pointed out by @pkulikov, I forgot to rename the later mentions of the "Local" function in the paragraph after the code snippet.
Corrected typo mistake
…4298) * Replaced fwlink in concepts/async except index.md * Fix link error * Test uwp fwlink replace * replace fwlink in concepts/async/index.md * text xref with uwp links * uwp/api links -> xref links
* Revised for API Browser, .NET implementations * Incorporated review comments * Corrected System.Object for F#
* fix broken links and review topic * feedback * feedback
* replace wrong example * removed examples
* fix broken links * Revised link Revised Working with Visual Studio For Docker Tools link
* Replaced fwlinks in csharp\programming-guide folder * Implemented review feedback
One of the comments provided was a desire to link this document to the actual specification, so I add that.
The section title was missing
The title looked awful in the live site and I think this new one is simpler
To be more concise and understandable.
* checkin source from wiwki This commit addes the following: 1. Import syntax visualizer doc from roslyn-wiki: https://github.com/dotnet/roslyn/wiki/Syntax%20Visualizer 2. Add images. 3. provide include for installation instructions. 4. update index and TOC. * review and update The existing text was written when the SDK was in preview mode. All screenshots have been updated. The text was updated for product names, formatted, and reviewed. * proofread and update * respond to feedback. * respond to feedback * fix install notes * respond to feedback.
* Added include, slightly simplified installation guide * Addressed review comments * Added information on VIsual Studio Installer * Addressed review comments
mairaw
requested changes
Mar 29, 2018
xml/System/DateTime.xml
Outdated
| @@ -116,7 +116,7 @@ Time values are measured in 100-nanosecond units called ticks. A particular date | |||
| > [!NOTE] | |||
| > If you are working with a ticks value that you want to convert to some other time interval, such as minutes or seconds, you should use the <xref:System.TimeSpan.TicksPerDay?displayProperty=nameWithType>, <xref:System.TimeSpan.TicksPerHour?displayProperty=nameWithType>, <xref:System.TimeSpan.TicksPerMinute?displayProperty=nameWithType>, <xref:System.TimeSpan.TicksPerSecond?displayProperty=nameWithType>, or <xref:System.TimeSpan.TicksPerMillisecond?displayProperty=nameWithType> constant to perform the conversion. For example, to add the number of seconds represented by a specified number of ticks to the <xref:System.DateTime.Second%2A> component of a <xref:System.DateTime> value, you can use the expression `dateValue.Second + nTicks/Timespan.TicksPerSecond`. | |||
|
|
|||
| You can view the source for the entire set of examples from this article in either [Visual Basic](https://github.com/dotnet/docs/tree/master/samples/snippets/visualbasic/System.DateTime/) or [C#](https://github.com/dotnet/docs/tree/master/samples/snippets/csharp/System.DateTime/) from the docs repository on GitHub. | |||
| You can view the source for the entire set of examples from this article in either [Visual Basic](https://github.com/dotnet/samples/tree/master/samples/snippets/visualbasic/System.DateTime/) or [C#](https://github.com/dotnet/samples/tree/master/samples/snippets/csharp/System.DateTime/) from the docs repository on GitHub. | |||
There was a problem hiding this comment.
you also need to remove the inner samples from the URLs. e.g.
https://github.com/dotnet/samples/tree/master/snippets/visualbasic/System.DateTime/
|
@BillWagner ugh. now we can see what's going to happen when we rewrite history on dotnet/docs with open PRs. Need to think what to do there. |
|
@mairaw I have a thought on a process to resolve these after rewriting history. I'll play around with some experiments this morning. |
Partial fix for dotnet/docs#4821 The samples repo moved all the samples out of a "samples" repo.
ccfe1aa to
957643f
Compare
Merged
|
The changes for this PR have been moved to PR #2. To make this PR, I first squashed the 2 commits in PR #1. (Not necessary, but saved a bit of time) Then, I made a new branch, and cherry-picked the commit from PR 1. The proved much easier than merging or re-basing after rewriting history on the master branch. |
sdmaclea
pushed a commit
to sdmaclea/dotnet-api-docs
that referenced
this pull request
Jun 6, 2019
* Define basic process * Update per feedback
Passionschadmichaelsheda
added a commit
to Passionschadmichaelsheda/dotnet-api-docs
that referenced
this pull request
Aug 9, 2021
ryalanms
added a commit
to ryalanms/dotnet-api-docs
that referenced
this pull request
Sep 13, 2021
ryalanms
added a commit
to ryalanms/dotnet-api-docs
that referenced
this pull request
Sep 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for dotnet/docs#4821