10000 Samples fixes for Batch 13 of .NET Interactive changes by mairaw · Pull Request #4457 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]
Skip to content

Samples fixes for Batch 13 of .NET Interactive changes #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2020
Merged

Samples fixes for Batch 13 of .NET Interactive changes #4457

merged 2 commits into from
Jul 1, 2020

Conversation

mairaw
Copy link
Contributor
@mairaw mairaw commented Jul 1, 2020

Mostly output fixes and also removal of a call to Console.ReadLine so the sample works on .NET Interactive

@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 1, 2020
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Jul 1, 2020
@mairaw mairaw requested a review from a team July 1, 2020 02:31
BillWagner
BillWagner approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member
@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @mairaw

I'll :shipit: now

@BillWagner BillWagner merged commit 8edf14d into dotnet:master Jul 1, 2020
@v-mepa v-mepa mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @BillWagner @dotnet-bot
0