8000 [Port for release/6.0] Ignore processing collation for JSON output params and enhance test coverage by apoorvdeshmukh · Pull Request #3173 · dotnet/SqlClient · GitHub
[go: up one dir, main page]
Skip to content

[Port for release/6.0] Ignore processing collation for JSON output params and enhance test coverage #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

[Port for release/6.0] Ignore processing collation for JSON output params and enhance test coverage #3173

merged 1 commit into from
Feb 21, 2025

Conversation

apoorvdeshmukh
Copy link
Contributor

Ports #3168 to release/6.0 branch

@apoorvdeshmukh
Ignore processing collation for JSON output params and enhance test c…
de50ec2 
…overage (#3168)

This commit fixes #3167 where reading output parameter of type JSON resulted in an error.
Additionally, test coverage has been enhanced to include tests for insertions and reads
with SqlJson and output parameters of type JSON.
@apoorvdeshmukh apoorvdeshmukh added this to the 6.0.2 milestone Feb 21, 2025
@apoorvdeshmukh apoorvdeshmukh requested a review from a team February 21, 2025 06:57
@codecov Codecov
Copy link
codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (cfb007d) to head (de50ec2).
Report is 2 commits behind head on release/6.0.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release/6.0    #3173      +/-   ##
===============================================
- Coverage        72.78%   72.61%   -0.18%     
===============================================
  Files              285      285              
  Lines            59162    59162              
===============================================
- Hits             43064    42960     -104     
- Misses           16098    16202     +104
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.41% <100.00%> (-0.14%) ⬇️
netfx 71.02% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apoorvdeshmukh apoorvdeshmukh merged commit ef082bc into release/6.0 Feb 21, 2025
252 checks passed
@apoorvdeshmukh apoorvdeshmukh deleted the dev/apoorvdeshmukh/port3168 branch February 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdaigle mdaigle mdaigle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@apoorvdeshmukh @mdaigle
0