8000 Ignore processing collation for JSON output params and enhance test c… by apoorvdeshmukh · Pull Request #3168 · dotnet/SqlClient · GitHub
[go: up one dir, main page]
Skip to content

Ignore processing collation for JSON output params and enhance test c… #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Ignore processing collation for JSON output params and enhance test c… #3168

merged 1 commit into from
Feb 21, 2025

Conversation

apoorvdeshmukh
Copy link
Contributor

Fixes #3167
Added test Coverage for some of the missing scenarios.

@apoorvdeshmukh apoorvdeshmukh requested a review from a team February 20, 2025 17:03
@apoorvdeshmukh apoorvdeshmukh added this to the 6.0.2 milestone Feb 20, 2025
@mdaigle mdaigle modified the milestones: 6.0.2, 7.0-preview1 Feb 20, 2025
@codecov Codecov
Copy link
codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.13%. Comparing base (17cb0b0) to head (6c689ee).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (17cb0b0) and HEAD (6c689ee). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (17cb0b0) HEAD (6c689ee)
addons 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
- Coverage   72.96%   66.13%   -6.84%     
==========================================
  Files         283      279       -4     
  Lines       58997    58945      -52     
==========================================
- Hits        43048    38981    -4067     
- Misses      15949    19964    +4015
Flag Coverage Δ
addons ?
netcore 69.20% <100.00%> (-6.53%) ⬇️
netfx 64.81% <100.00%> (-6.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apoorvdeshmukh apoorvdeshmukh merged commit 3d652d4 into dotnet:main Feb 21, 2025
123 checks passed
@apoorvdeshmukh apoorvdeshmukh deleted the dev/jsonOutParamFix branch February 21, 2025 06:53
apoorvdeshmukh added a commit that referenced this pull request Feb 21, 2025
@apoorvdeshmukh
Ignore processing collation for JSON output params and enhance test c…
de50ec2 
…overage (#3168)

This commit fixes #3167 where reading output parameter of type JSON resulted in an error.
Additionally, test coverage has been enhanced to include tests for insertions and reads
with SqlJson and output parameters of type JSON.
@apoorvdeshmukh apoorvdeshmukh mentioned this pull request Feb 21, 2025
Merged
apoorvdeshmukh added a commit that referenced this pull request Feb 21, 2025
@apoorvdeshmukh
Ignore processing collation for JSON output params and enhance test c…
ef082bc 
…overage (#3168) (#3173)

This commit fixes #3167 where reading output parameter of type JSON resulted in an error.
Additionally, test coverage has been enhanced to include tests for insertions and reads
with SqlJson and output parameters of type JSON.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh500 saurabh500 saurabh500 approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

Error reading the output parameter of type JSON while executing stored procedure
4 participants
@apoorvdeshmukh @saurabh500 @paulmedynski @mdaigle
0