10000 Removed kernel.debug from cache namespace seed by Sander-Toonen · Pull Request #108 · doctrine/DoctrineCacheBundle · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Removed kernel.debug from cache namespace seed #108

Merged
merged 2 commits into from
Dec 7, 2016

Conversation

Sander-Toonen
Copy link

The kernel.debug should imho not be part of the namespace seed. See symfony/symfony#20780. A similar PR has been created for the Symfony FrameworkBundle (symfony/symfony#20816).

@nicolas-grekas
Copy link
Member
nicolas-grekas 8000 commented Dec 7, 2016

For reviewers: looking at kernel.debug has been introduced recently in #105.
@Sander-Toonen please update tests btw

@mikeSimonson
Copy link
Contributor

Thanks.

@mikeSimonson mikeSimonson merged commit 8f99362 into doctrine:master Dec 7, 2016
@Sander-Toonen
Copy link
Author

Thank you!

@Sander-Toonen Sander-Toonen deleted the fix-namespace-seed branch December 7, 2016 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0