8000 [FrameworkBundle] Don't seed cache pool namespaces with kernel debug · Issue #20780 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Don't seed cache pool namespaces with kernel debug #20780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sander-Toonen opened this issue Dec 6, 2016 · 2 comments
Closed

[FrameworkBundle] Don't seed cache pool namespaces with kernel debug #20780

Sander-Toonen opened this issue Dec 6, 2016 · 2 comments
Labels
Cache FrameworkBundle
Milestone
3.1

Comments

@Sander-Toonen
Copy link
Contributor
Sander-Toonen commented Dec 6, 2016 •
edited
Loading

I was wondering whether there was a specific reason to include kernel.debug in the cache pool namespace seed. Imho setting/unsetting the debug flag should not have an effect on the workings of a program.

#18544 added the kernel.name, kernel.root_dir, kernel.environment and kernel.debug to the cache pool namespace.

Consider this scenario:
A user has a website that displays values from a database which are cached. A worker (console command) updates values in the database and busts the corresponding cache keys. In order to find a problem in the worker, the user wants to log some more details and restarts the workers without the --no-debug flag. Now suddenly, the cache isn't busted anymore and no information gets updated on the UI.

I would therefore suggest removing kernel.debug from the cache pool seed.
@nicolas-grekas
Copy link
Member

I would therefore suggest removing kernel.name from the cache pool seed.

I guess you mean kernel.debug. Please open PR (against on 3.1?) so that we can discuss that there. Looks fine to me. Please also open one against DoctrineCacheBundle since it has the same issue since doctrine/DoctrineCacheBundle#105

@Sander-Toonen
Copy link
Contributor Author

@nicolas-grekas Oops, yes. I changed it.

Ok. I will.

@nicolas-grekas nicolas-grekas added this to the 3.1 milestone Dec 6, 2016
This was referenced Dec 7, 2016
Merged
Merged
fabpot added a commit that referenced this issue Dec 8, 2016
@fabpot
bug #20816 [FrameworkBundle] Removed kernel.debug from the cache pool…
4317a7a 
… namespace seed (Sander Toonen)

This PR was merged into the 3.1 branch.

Discussion
----------

[FrameworkBundle] Removed kernel.debug from the cache pool namespace seed

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20780
| License       | MIT
| Doc PR        |

Commits
-------

8e1dac5 [FrameworkBundle] Removed the kernel.debug parameter from the cache pool namespace seed
@fabpot fabpot closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cache FrameworkBundle
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @nicolas-grekas @Sander-Toonen
0