8000 fix: Allow lazy wizard initialization by fsbraun · Pull Request #8267 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

fix: Allow lazy wizard initialization #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 28, 2025
Merged

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Jun 28, 2025

Description

Backport of #8265
-->

Related resources

Checklist

  • I have opened this pull request against main
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Replace deprecated wizard_pool usage with get_entry and adjust its deprecation version.

Enhancements:

  • Import get_entry from wizard_base and use it in WizardCreateView instead of wizard_pool.get_entry
  • Update wizard_pool deprecation warning to target removal in DjangoCMS 5.0

Copy link
Contributor
sourcery-ai bot commented Jun 28, 2025

Reviewer's Guide

This PR removes direct use of the deprecated wizard_pool API by replacing it with the new get_entry helper and updates the deprecation warning to target the upcoming CMS 5.0 release.

Class diagram for Wizard entry retrieval update

classDiagram
    class WizardCreateView {
        +get_selected_entry()
    }
    class wizard_pool {
        +get_entry()
    }
    class get_entry
    WizardCreateView --> get_entry : uses
    %% wizard_pool is no longer used directly by WizardCreateView
Loading

Class diagram for updated deprecation warning in wizard_pool

classDiagram
    class wizard_pool {
        +register(entry)
    }
    class RemovedInDjangoCMS50Warning
    wizard_pool ..> RemovedInDjangoCMS50Warning : uses in warning
Loading

File-Level Changes

Change Details Files
Replaced wizard_pool.get_entry with get_entry helper
  • Updated import from wizard_base.get_entry
  • Changed get_selected_entry to call get_entry instead of wizard_pool.get_entry
cms/wizards/views.py
Bumped deprecation warning version
  • Changed RemovedInDjangoCMS51Warning to RemovedInDjangoCMS50Warning in warnings.warn call
cms/wizards/wizard_pool.py
Removed deprecated wizard_pool import from ancillary modules
  • Deleted unused wizard_pool import in helpers
  • Cleaned up related imports in tests
cms/wizards/helpers.py
cms/tests/test_grouper_admin.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun changed the title fix: Wizard pool depr message feat: Allow lazy wizard initialization Jun 28, 2025
@fsbraun fsbraun changed the title feat: Allow lazy wizard initialization fix: Allow lazy wizard initialization Jun 28, 2025
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

fsbraun and others added 2 commits June 28, 2025 16:51
…views (#8067)

* Fix: GrouperModelAdmin raised an AttributeError if used outside the admin app

* Fixed: Page.__str__ returns page title with admin_manager

* feat: Format `Page.__str__` as "My title (/path/to/page/)"

* Update tests for new str method of Page

* Simplify str

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
…views (#8067)

* Fix: GrouperModelAdmin raised an AttributeError if used outside the admin app

* Fixed: Page.__str__ returns page title with admin_manager

* feat: Format `Page.__str__` as "My title (/path/to/page/)"

* Update tests for new str method of Page

* Simplify str

---------

Co-authored-by: Github Release Action <info@django-cms.org>
Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

Copy link

👋 Hi there!

Please remember to MERGE COMMIT pull requests from develop or develop-4!

Do not SQUASH commits to preserve history for the changelog.

@fsbraun fsbraun merged commit 04003bb into release/4.1.x Jun 28, 2025
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0