fix: Grouper admin raised AttributeError when used outside the admin views #8067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vinitkumar
requested changes
Nov 6, 2024
marksweb
approved these changes
Nov 6, 2024
added 5 commits
November 6, 2024 18:39
a6ac486 to
13f9e5a
Compare
vinitkumar
approved these changes
Nov 6, 2024
8000
4 tasks
fsbraun
added a commit
that referenced
this pull request
Jun 28, 2025
…views (#8067) * Fix: GrouperModelAdmin raised an AttributeError if used outside the admin app * Fixed: Page.__str__ returns page title with admin_manager * feat: Format `Page.__str__` as "My title (/path/to/page/)" * Update tests for new str method of Page * Simplify str --------- Co-authored-by: Github Release Action <info@django-cms.org> Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
fsbraun
added a commit
that referenced
this pull request
Jun 28, 2025
…views (#8067) * Fix: GrouperModelAdmin raised an AttributeError if used outside the admin app * Fixed: Page.__str__ returns page title with admin_manager * feat: Format `Page.__str__` as "My title (/path/to/page/)" * Update tests for new str method of Page * Simplify str --------- Co-authored-by: Github Release Action <info@django-cms.org> Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
fsbraun
added a commit
that referenced
this pull request
Jun 28, 2025
* fix: Wizard pool depr message * fix: Add hash method to FizzyInt for testing * fix: Grouper admin raised AttributeError when used outside the admin views (#8067) * Fix: GrouperModelAdmin raised an AttributeError if used outside the admin app * Fixed: Page.__str__ returns page title with admin_manager * feat: Format `Page.__str__` as "My title (/path/to/page/)" * Update tests for new str method of Page * Simplify str --------- Co-authored-by: Github Release Action <info@django-cms.org> Co-authored-by: Vinit Kumar <mail@vinitkumar.me> * fix: Grouper admin raised AttributeError when used outside the admin views (#8067) * Fix: GrouperModelAdmin raised an AttributeError if used outside the admin app * Fixed: Page.__str__ returns page title with admin_manager * feat: Format `Page.__str__` as "My title (/path/to/page/)" * Update tests for new str method of Page * Simplify str --------- Co-authored-by: Github Release Action <info@django-cms.org> Co-authored-by: Vinit Kumar <mail@vinitkumar.me> * Fix linting error * Update node dependencies * Add missing import --------- Co-authored-by: Github Release Action <info@django-cms.org> Co-authored-by: Vinit Kumar <mail@vinitkumar.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fallback methods to
GrouperModelAdminto allow for fallback methods if not all grouping fields are set. This allows to useGrouperModelAdminoutside the admin views, e.g., as a target for theAutocompleteSelectwidget.It makes pages searchable by adding search fields. Also, the page's str method is updated for search fields: This way pages are consistently represented in the admin by (
str(page)) in the form of "My page title (/path/to/page)" in the current or a fallback language.Finally, a type hint error is fixed.
Related resources
Checklist
develop-4