8000 fix: Menus crashed when unexpected page content was present by fsbraun · Pull Request #8052 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Menus crashed when unexpected page content was present #8052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 4, 2024
Merged

fix: Menus crashed when unexpected page content was present #8052

merged 15 commits into from
Nov 4, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Oct 31, 2024 •
edited
Loading

Description

This PR fixes two issues with correct page content retrieval (fixes #8040 and #8037). Menus raised an exception if a page content for a non-configured language was present, but no page URL.

Due to the new menu system in 4.2 (#7956), this bug is not present in develop-4.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from a team October 31, 2024 06:26
@fsbraun fsbraun added the 4.1 label Oct 31, 2024
@fsbraun fsbraun changed the title Fix: Menus crashed when unexpected page content was present fix: Menus crashed when unexpected page content was present Oct 31, 2024
@fsbraun fsbraun force-pushed the chore/backport-8086 branch 3 times, most recently from fb6630f to 7ba33e6 Compare October 31, 2024 07:12
@fsbraun fsbraun force-pushed the chore/backport-8086 branch from 2606570 to 9de4edb Compare October 31, 2024 07:46
@fsbraun fsbraun force-pushed the chore/backport-8086 branch from f410d2f to 97b1314 Compare October 31, 2024 09:42
@fsbraun fsbraun force-pushed the chore/backport-8086 branch from 97b1314 to 5077acc Compare October 31, 2024 09:47
@fsbraun fsbraun merged commit dd0842a into django-cms:release/4.1.x Nov 4, 2024
101 of 112 checks passed
@fsbraun fsbraun deleted the chore/backport-8086 branch November 4, 2024 10:19
@fsbraun fsbraun mentioned this pull request Nov 5, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @marksweb
0