8000 fix: In rare situations the page tree preview button did not view the latest version by MacLake · Pull Request #8050 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

fix: In rare situations the page tree preview button did not view the latest version #8050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

MacLake
Copy link
Contributor
@MacLake MacLake commented Oct 30, 2024

Description

When opening a page, I expect the latest version to show up by default, which is what happens when I open a page via the front end menu. But when you open a page via the pages overview, it might happen that you get to the first version. This is confusing for editors. And then they are tempted to click the blue highlighted “Revert” button without really knowing what this is doing: creating yet another version that is a copy of version 1.

Related resources

Fixes #8037

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun changed the title Select latest version fix: In rare situations the page tree preview button did not view the latest version Oct 30, 2024
…ew in admin

Without applying .latest_content() on the queryset it could happen that an
old version was opened when clicking on the eye icon of a page in the pages overview.
@MacLake MacLake force-pushed the select_latest_version branch from 22dccd7 to dfb0483 Compare October 30, 2024 20:52
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@fsbraun fsbraun merged commit 052eac5 into django-cms:develop-4 Oct 31, 2024
51 checks passed
@MacLake MacLake deleted the select_latest_version branch November 22, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clicking on “View on site” button in pages overview gets you to first instead of latest version
2 participants
0