chore: Django 5.2-compatible test fixtures #8008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksweb
approved these changes
Sep 22, 2024
3554581 to
747f660
Compare
|
This looks like it fixes those failing tests that I hadn't worked out a fix for yet in my PR 👏 |
fsbraun
added a commit
that referenced
this pull request
Sep 23, 2024
* chore: Re-hook fixture loading to stay compatible with django 5.2 * Remove Postgres pin to v12 for testing * Exclude Py39 from dj51 * Pin postgres to version 15 * Switch from psycopg2 to recommended psycopg>=3.1.8 --------- Co-authored-by: Github Release Action <info@django-cms.org>
4 tasks
fsbraun
added a commit
that referenced
this pull request
Oct 7, 2024
* [4.1.3 release process] Building locales * [4.1.3 release process] Bumped version to 4.1.3 * [4.1.3 release process] compilemessages * [4.1.3 release process] compiling new static files * [4.1.3 release process] updating latest docs * Update CHANGELOG.rst * Update 4.1.3.rst * Update 4.1.3.rst * chore: Django 5.2-compatible test fixtures (#8008) * chore: Re-hook fixture loading to stay compatible with django 5.2 * Remove Postgres pin to v12 for testing * Exclude Py39 from dj51 * Pin postgres to version 15 * Switch from psycopg2 to recommended psycopg>=3.1.8 --------- Co-authored-by: Github Release Action <info@django-cms.org> * Update CHANGELOG.rst typo * chore: Backport #8021 * fix: Update databases.txt to include psycopg2 for Django < 4.2 * fix: Mark language and user middleware synchronous for ASGI (Backport of #7986) --------- Co-authored-by: Github Release Action <info@django-cms.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
CMSBaseTestCaseto stay compatible with Django 5.2. (Fixes #8006 )Fixtures were loaded in
_fixture_setup()which will turn into a classmethod in Django 5.2. Since theCMSBaseTestCaseAPI expects the fixtures to be in a regular method, they are now loaded in_pre_setup().Related resources
CMSBaseTestCase#8006Checklist
develop-4