8000 ci: Test python 3.13 and django 5.1 by marksweb · Pull Request #7941 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

ci: Test python 3.13 and django 5.1 #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

ci: Test python 3.13 and django 5.1 #7941

wants to merge 10 commits into from

Conversation

marksweb
Copy link
Member
@marksweb marksweb commented Jun 24, 2024 •
edited
Loading

Description

This adds to github tests, python 3.13 and django 5.1.

I've also removed testing against old django releases.

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@marksweb
Copy link
Member Author

Some of the test failures I've seen come from a case of <h2>Page Permissions</h2> not in str type error where I can see that there is heading of <h2>permissions</h2>. So I'm just wondering there if this is a django admin based test where the setup of django admin has changed or if this is an unrelated permissions section (it's painful to read the raw HTML output afterall so I may have missed/misunderstood something)

@fsbraun
Copy link
Member
fsbraun commented Jul 10, 2024

I've looked at the HTML. It seems that django has introduced some classes to the <h2> tag which make this test fail.

@marksweb marksweb self-assigned this Sep 4, 2024
@vinitkumar
Copy link
Member

@marksweb Let's resolve the merge conflicts and see if the new code fixes the test failures.

@vinitkumar
Copy link
Member

@marksweb I think the latest https://github.com/django-cms/django-cms/blob/develop-4/.github/workflows/test.yml already has this. Do we need this PR anymore?

@fsbraun
Copy link
Member
fsbraun commented Sep 30, 2024

Superseded by #8008

@fsbraun fsbraun closed this Sep 30, 2024
@fsbraun fsbraun deleted the ci/test-upcoming branch April 5, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marksweb marksweb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marksweb @fsbraun @vinitkumar
0