chore: Improve pagecontent caching in page admin (esp. page tree) #8002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinitkumar
approved these changes
Sep 18, 2024
fsbraun
added a commit
to fsbraun/django-cms
that referenced
this pull request
Sep 19, 2024
…ango-cms#8002) * Fix: Separate cache and access methods for page admin to hold available page contents * Fix typo * Remove `EmptyPageContent` from admin_content_cache * Optimize queryset for pagetree --------- Co-authored-by: Github Release Action <info@django-cms.org>
4 tasks
fsbraun
added a commit
that referenced
this pull request
Sep 20, 2024
…e tree) (#8002) (#8004) * chore: Improve pagecontent caching in page admin (esp. page tree) (#8002) * Fix: Separate cache and access methods for page admin to hold available page contents * Fix typo * Remove `EmptyPageContent` from admin_content_cache * Optimize queryset for pagetree --------- Co-authored-by: Github Release Action <info@django-cms.org> * Add back template file * Undo permission check change (error when merging) * Undo more merge errors * Fix: missing warning import * Clarify an isort/ruff dispute * Add write permission * Add admin cache to cms_toolbars.py * fix typo in cms_toolbars.py --------- Co-authored-by: Github Release Action <info@django-cms.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Historically, django CMS has used a python cache on model level for page content objects:
page.page_content_cache.Since django CMS 4., this cache is filled either with user-visible objects (using the default
objectsmanager) or with admin-visible objects, using theadmin_managermanager. Since each request is, either from the user side or the admin side, this same cache can be used to hold different sets of page content objects. A side effect, however, lead to some page titles in fallback languages not to be shown in the page tree.It turns out, however, that this was not consistently done, leading to unnecessary cache misses.
This PR splits the caches into
page_content_cache(traditional, user-facing) andadmin_content_cachefor the page admin, to make sure no side effects can happen.This improves the cache hits and reduces the number of database hits for the page tree effectively removing a hidden N+1 issue. The response time should improve by 20%+ (tested with local sqlite).
Related resources
Checklist
develop-4