8000 Refactor get_title_obj in django-cms · Issue #212 · django-cms/djangocms-versioning · GitHub
[go: up one dir, main page]

Skip to content
Refactor get_title_obj in django-cms #212
Closed
@jonathan-s

Description

@jonathan-s

When using django-cms together with versioning it's important to keep apart content/objects that should be displayed to the end user and content/objects that can be viewed by an admin user.

get_title_obj is used in several places to assign the object both in toolbars (admin related) and in places that will render to the end user.

There has been a lot of monkeypatching going on in djangocms-versioning to account for this fact. By creating a method get_admin_title_obj this method alone could be monkeypatched instead of spreading out the monkeypatching. If/when versioning is incorporated into core it would also make things easier to incorporate any monkeypatches into this method.

This will also start to setup us up for a clean separation between what is viewable by admin users and what is viewable by end users.

This is also related to the following PR > django-cms/django-cms#6817 instead of that implementation it would be better if it used get_admin_title_obj

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0