8000 feat: Add RTL support to modal header and related components by sakhawy · Pull Request #7863 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

feat: Add RTL support to modal header and related components #7863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024
Merged

feat: Add RTL support to modal header and related components #7863

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d64a180
feat: Add RTL support to modal header and related components
sakhawy Apr 1, 2024
91cf111
fix: followup fixes
sakhawy Apr 5, 2024
1bf9c6a
fix: Remove dir attribute from div.cms-modal
sakhawy Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Remove dir attribute from div.cms-modal
  • Loading branch information
@sakhawy
sakhawy committed Apr 23, 2024
commit 1bf9c6a531ac84580eff19c8de8eb4ea6dbd20a1
3 changes: 0 additions & 3 deletions cms/templates/cms/toolbar/toolbar_with_structure.html
View file 7AF4
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,10 @@
{% include 'cms/toolbar/clipboard.html' with clipboard_plugin=cms_toolbar.clipboard_plugin %}
{% endif %}

<!-- TODO: Remove lang and dir once RTL support is added to toolbar -->
<div
class="cms-modal"
tabindex="-1"
data-touch-action="none"
lang="{{ LANGUAGE_CODE|default:"en-us" }}"
dir="{{ LANGUAGE_BIDI|yesno:'rtl,ltr,auto' }}"
>
<div class="cms-modal-head" data-touch-action="none">
<span class="cms-modal-title" data-touch-action="none">
Expand Down
0