feat: Add RTL support to modal header and related components #7863
Conversation
|
@fsbraun / @sakhawy , |
There was a problem hiding this comment.
@sakhawy This is cool stuff! Looks great.
I have two comments for the structure board.
Also, I can imagine going one last step further: Also make the toolbar RTL, i.e. the structure board on the left, the admin sidebar on the right and the menu from rtl. What do you think?
|
Thanks for the review @fsbraun! The toolbar is the very next thing on my list but is it good for the scope of this PR? Should I open up another one or just make the changes here? |
|
@sakhawy You can surely do this in a separate PR. Then I'd suggest a different approach for putting the
This way all the other components (modal, structure board, ...) will use the direction of the document. The toolbar itself will be forced to be ltr. This What do you think? |
|
Following the plan, since the modal inherits to |
|
@sakhawy Can you check if this change is still up-to-date? django-cms/cms/templates/cms/toolbar/toolbar_with_structure.html Lines 37 to 44 in 898a14a If so, I will merge and include the PR in django CMS 4.1.1. |
898a14a to
1bf9c6a
Compare
|
@fsbraun I removed the |
…7902) (#7914) * feat: Add RTL support to toolbar (#7871) * feat: Add RTL support to toolbar * fix: Add logical text-align value for toolbar dropdown * fix: Correctly calculate available width of toolbar * fix: Fix weird floating bug with toolbar more buttons * feat: Add RTL support to modal header and related components (#7863) * fix: structure board on the right for ltr * Fix: also use key-length of 200 for the actual cache-key of placeholders - missing "functionality" for changes of #7595 and #7657 * fix: Set toolbar direction based on toolbar language (#7902) * Fix: Merge remnant * Update make-release script --------- Co-authored-by: Moe <mohammadalsakhawy@gmail.com> Co-authored-by: Wolfga 6AD7 ng Fehr <24782511+wfehr@users.noreply.github.com>
Description
Followup to #525.
I touched related files for style consistency.
Related resources
Screenshots
Checklist
develop-4