8000 fix: Port forward #7070 - faster DOM update after editing by fsbraun · Pull Request #7787 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Port forward #7070 - faster DOM update after editing #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 4, 2024
Merged

fix: Port forward #7070 - faster DOM update after editing #7787

merged 5 commits into from
Feb 4, 2024

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Jan 28, 2024

Description

This PR ports forward the fix #7070 which improves editing workflow (solving #7069) by avoiding unresponsive pages.

The original fix in #7070 was amended by #7223 which is also included here.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

nichoski and others added 2 commits January 28, 2024 01:40
@nichoski @fsbraun
Fixed browser freezing on cms toolbar markup refresh after plugin edit (
3a204f5 
django-cms#7070)

* Fixed browser freezing on cms toolbar markup refresh after plugin edit

* Updated tests to work with fix

* Removed unused variables

* Removing unused Diff-DOM definition
@fsbraun
Fix typos and accidentally deleted imports during the merge
49602da
fsbraun
fsbraun commented Jan 28, 2024
View reviewed changes
@fsbraun fsbraun requested review from a team and vinitkumar January 28, 2024 01:04
@marksweb
Copy link
Member
marksweb commented Feb 3, 2024

What was the diff providing here?

@fsbraun
Copy link
Member Author
fsbraun commented Feb 3, 2024

@marksweb The diff calculates the differences between the old and new toolbar and then replaces the DOM elements. That led to performance issues (#7069) and was removed in v3 in 3.9 or 3.10. The toolbar is of moderate size, and a full replacement works faster and more reliably.

@vinitkumar vinitkumar merged commit 26b081a into django-cms:develop-4 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsbraun @marksweb @vinitkumar @nichoski
0