Fixed browser freezing on cms toolbar markup refresh after plugin edit #7070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd79bd9 to
004d1da
Compare
|
@nichoski The code looks good. If possible, can you please post a GIF or video of this fixing the slowness of diff creation comparing it to old code? That would be really nice to be documented here. Thanks. |
|
@nichoski There is a failing test. Please make sure that the tests are passing. |
|
Yes @vinitkumar I saw it. I'll fix it soon. |
|
@vinitkumar the test is fixed. Please review when you can. |
vinitkumar
approved these changes
Jun 8, 2021
marksweb
approved these changes
Jun 8, 2021
4 tasks
fsbraun
pushed a commit
to fsbraun/django-cms
that referenced
this pull request
Jan 28, 2024
django-cms#7070) * Fixed browser freezing on cms toolbar markup refresh after plugin edit * Updated tests to work with fix * Removed unused variables * Removing unused Diff-DOM definition
4 tasks
vinitkumar
pushed a commit
that referenced
this pull request
Feb 4, 2024
* Fixed browser freezing on cms toolbar markup refresh after plugin edit (#7070) * Fixed browser freezing on cms toolbar markup refresh after plugin edit * Updated tests to work with fix * Removed unused variables * Removing unused Diff-DOM definition * Fix typos and accidentally deleted imports during the merge * Update cms/static/cms/js/modules/cms.changeform.js --------- Co-authored-by: nichoski <nichoski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related resources
This fixes the bug reported here:
#7069
To update the contents of the django-cms toolbar after a plugin update, instead of creating a diff between old content and new content and applying the diff, this fix simply replaces the old content with the new content. This is because on sites with more content, the diff creating process is incredibly slow. Please see issue 7069 for more info.
develop