8000 fix: #7745 -- permission handling when deleting page by jrief · Pull Request #7747 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: #7745 -- permission handling when deleting page #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: #7745 -- permission handling when deleting page #7747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix issue #7745 
discard specific verbose_name from perms_needed
  • Loading branch information
@jrief
jrief committed Jan 9, 2024
commit d8f73fd408666bc448b6522e247d2b34975df812
10 changes: 4 additions & 6 deletions cms/admin/pageadmin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,12 +371,10 @@ def delete_view(self, request, object_id, extra_context=None):
**get_deleted_objects_additional_kwargs
)

# This is bad and I should feel bad.
if _('placeholder') in perms_needed:
perms_needed.remove('placeholder')

if _('page content') in perms_needed:
perms_needed.remove('page content')
# `django.contrib.admin.utils.get_deleted_objects()` only returns the verbose_name of a model,
# we hence have to use that name in order to allow the deletion of objects otherwise prevented.
perms_needed.discard(Placeholder._meta.verbose_name)
perms_needed.discard(PageContent._meta.verbose_name)

if request.POST and not protected: # The user has confirmed the deletion.
if perms_needed:
Expand Down
0