8000 fix: #7745 -- permission handling when deleting page by jrief · Pull Request #7747 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: #7745 -- permission handling when deleting page #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: #7745 -- permission handling when deleting page #7747

merged 1 commit into from
Jan 10, 2024

Conversation

jrief
Copy link
Contributor
@jrief jrief commented Jan 9, 2024

discard specific verbose_name from perms_needed

Description

This fixes #7746 , check issue for details.

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@jrief
fix issue django-cms#7745
d8f73fd 
discard specific verbose_name from perms_needed
@jrief jrief changed the title fix issue #7745 fix #7745: permission handling when deleting page Jan 9, 2024
@fsbraun fsbraun changed the title fix #7745: permission handling when deleting page fix: #7745 -- permission handling when deleting page Jan 9, 2024
fsbraun
fsbraun approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member
@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I was not aware that perms_needed actually is a set. :-)

@jrief
Copy link
Contributor Author
jrief commented Jan 9, 2024

Nice. I was not aware that perms_needed actually is a set. :-)

and this is true for all supported Django versions (>3.0), hence using .discard() is safe.

@fsbraun fsbraun merged commit e0c7550 into django-cms:develop-4 Jan 10, 2024
@fsbraun fsbraun mentioned this pull request Mar 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
4.1 needs port to 4.1.x status: ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrief @fsbraun
0