Sites - Pass Site obj instead of pk when creating a StaticPlaceholder #6679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add original fix by @saqlainsyed007
09aced3 to
463984d
Compare
|
Please let me know if anything is missing. |
|
@michauds thanks for the request. Could you rebase to develop and also add a changelog entry? |
b5118b5 to
fe3ce77
Compare
…d_tests_for_79a35c1
|
Alright @FinalAngel , I updated the Changelog with a new section 3.8.0 since the PR is targeted for that version. |
…d_tests_for_79a35c1
11 tasks
FinalAngel
pushed a commit
to FinalAngel/django-cms
that referenced
this pull request
Nov 12, 2019
…django-cms#6679) * Pass site object instead of pk when rendering menu Add original fix by @saqlainsyed007 * Moved test to it's own class * Update changelog
FinalAngel
added a commit
that referenced
this pull request
Nov 12, 2019
* Improved and simplified permissions documentation (#6224) [ci-skip] * Updated branch policy (#6320) * Updated branch policy [ci only docs] * Removed feature branch notes from policy * Improve apphooks documentation (#6743) Remove a reference to `urls` attribute on AppHook class in the documentation. * Fix documentation bug regarding CMSPluginBase (#6744) The documentation advertises that you can set the module attribute of custom plugins to None. If the user attempts this django they won't be able to start up when django.contrib.admin.site.urls is included in urls.py (tested with django 1.11.25 and django-cms 3.7.0). * Added example of `get_plugin_instance` to the docs on nested plugins. (#6609) * Amend Changelog and fixes from merged PRs (#6755) * add missing changelog entries * update docs * updated changelog * updates from comments * Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (#6679) * Pass site object instead of pk when rendering menu Add original fix by @saqlainsyed007 * Moved test to it's own class * Update changelog * Do not let non-staff users to log in via CMS Toolbar (#6705) * Merged stale PR's (#6759) * add missing changelog entries * update docs * updated changelog * updates from comments * merge #6347 * merged #6530 * merge #6538 * merge #6549 * merge #6704 * changelog for #6705 * Update issue templates * Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls (#6738) * Refs #6737 -- Add test for apphooks urls config check * Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls When rewriting the apphooks urls in appresolver.recurse_patterns, the original RegexPattern.is_endpoint flag is lost, so urls with a callback view throws an "include with a route ending with a '$'" warning ('urls.W001'). @apphook_pool.register class MyApp(CMSApp): name = "MyApp" def get_urls(self, page=None, language=None, **kwargs): return [ re_path(r"^$", views.MyAppView.as_view(), name="my-app-index") # or this # path(r"", views.MyAppView.as_view(), name="my-app-index") ] $ ./manage.py check System check identified some issues: WARNINGS: ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs. This fix set the RegexPattern flag is_endpoint to True for callback views in appresolver.recurse_patterns as in https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70 * Updated documentation and files for 3.7 LTS (#6761) * general updates * updates from comments * update form comments
FinalAngel
added a commit
that referenced
this pull request
Nov 26, 2019
* Add missing parenthesis in code (#6677) (#6690) * Adding support for Django 2.2 LTS (#6655) (#6691) * New changes for cms 3.7 * Fix typo * Fixed issue with force_color * Removed unused import * Added docs to index.rst * Fixed travis jobs * Fixed force_color command * Changes after review * Fixed django version in setup * Update django-2.2.txt * Fixes test suite (#6688) (#6692) * add information for testing * fix tests * updated CHANGELOG * update * 1.8.5 * fix tests locally * update text * Release 3.7.0a1 (internal) (#6693) * bumped version to 3.7.0a1 * updated staticfiles * updated translations * Adapt test suite for recent Travis changes (#6709) (#6710) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to #6694 (#6696) (#6711) * Adapt test suite for recent Travis changes (#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to #6694 (#6696) * Fix content mode related to #6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (#6673) (#6712) * Adapt test suite for recent Travis changes (#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to #6694 (#6696) * Fix content mode related to #6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (#6673) * Add missing template context processor to self install docs Fixes #5828 * Reword self install docs for clarity * Add to AUTHORS file * Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase (#6667) (#6713) * Add 'prepopulated_fields' to ignore list Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin) * Update AUTHORS * Release 3.7.0rc1 (#6715) * update django version in sphinx * bumped version * updated existing translations * update static files * update docs * update authors file * Override urlconf_module so that Django system checks don't crash. (#6719) (#6723) * Add a test case for #6717. * Override urlconf_module so that Django system checks don't crash. Without this fix, Django system checks in Django 2.2 will try to resolve the "app_resolver" module, which does not exist. Overriding ``urlconf_module`` prevents the issue. Fixes #6717 * Release 3.7.0rc2 (#6724) * regenerated translation files * bumped version * update existing translation * compile static files * updated release notes * Updated compatibility table (#6727) * Release 3.7.0 (#6735) * Bumped version to 3.7.0 * updated translation files * added static files * Backport to prepare for 3.7.1 (#6762) * Improved and simplified permissions documentation (#6224) [ci-skip] * Updated branch policy (#6320) * Updated branch policy [ci only docs] * Removed feature branch notes from policy * Improve apphooks documentation (#6743) Remove a reference to `urls` attribute on AppHook class in the documentation. * Fix documentation bug regarding CMSPluginBase (#6744) The documentation advertises that you can set the module attribute of custom plugins to None. If the user attempts this django they won't be able to start up when django.contrib.admin.site.urls is included in urls.py (tested with django 1.11.25 and django-cms 3.7.0). * Added example of `get_plugin_instance` to the docs on nested plugins. (#6609) * Amend Changelog and fixes from merged PRs (#6755) * add missing changelog entries * update docs * updated changelog * updates from comments * Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (#6679) * Pass site object instead of pk when rendering menu Add original fix by @saqlainsyed007 * Moved test to it's own class * Update changelog * Do not let non-staff users to log in via CMS Toolbar (#6705) * Merged stale PR's (#6759) * add missing changelog entries * update docs * updated changelog * updates from comments * merge #6347 * merged #6530 * merge #6538 * merge #6549 * merge #6704 * changelog for #6705 * Update issue templates * Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls (#6738) * Refs #6737 -- Add test for apphooks urls config check * Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls When rewriting the apphooks urls in appresolver.recurse_patterns, the original RegexPattern.is_endpoint flag is lost, so urls with a callback view throws an "include with a route ending with a '$'" warning ('urls.W001'). @apphook_pool.register class MyApp(CMSApp): name = "MyApp" def get_urls(self, page=None, language=None, **kwargs): return [ re_path(r"^$", views.MyAppView.as_view(), name="my-app-index") # or this # path(r"", views.MyAppView.as_view(), name="my-app-index") ] $ ./manage.py check System check identified some issues: WARNINGS: ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs. This fix set the RegexPattern flag is_endpoint to True for callback views in appresolver.recurse_patterns as in https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70 * Updated documentation and files for 3.7 LTS (#6761) * general updates * updates from comments * update form comments * Further backports for 3.7.1 (#6768) * add newly generated strings * Fix simple typo: seperated -> separated (#6767) * Fix simple typo: seperated -> separated * Update CHANGELOG.rst * Update djangocms installer docs (#6764) * Release django CMS 3.7.1 (#6769) * update documentation * Bumped version to 3.7.1 * compiled available languages * update static files * fix build * bump date * rebundle
znbn
pushed a commit
to znbn/django-cms
that referenced
this pull request
Apr 14, 2020
* Fixed middleware setting fallback in compatibility function. Take 2 * Fixed django-cms#6037 -- Placeholders without content in edit mode should also fallback. (django-cms#6066) * Update ISSUE_TEMPLATE.md * Fixed django-cms#5740 -- Use the correct url when ManifestStaticFilesStorage or similar is used (django-cms#5993) * Fixed incorrect entry in CHANGELOG The fix in question landed on 3.4.5 and not 3.4.4 * Fixed integration tests * Add import MyApp model to the forms.py (django-cms#6051) * Fixed django-cms#6080 -- Adding plugins is allowed on placeholders with fallback content (django-cms#6082) * Fixed a bug where tooltip won't show up in some browsers * Added version compatibility chart (django-cms#6089) Fixes django-cms#6071 * Added a destroy method for the Plugin javascript class - Added the destroy method for the Plugin javascript class django-cms#6074 - Added the `uid` helper to properly identify any UI Element - Created aliases to the wrapped `$(window)` and `$(document)` objects - Added the `destroy` method to the Plugin class removing DOM and events - Added unit tests and fix the old failing tests - Added the .cleanup method to remove plugin DOM nodes * Used plugin_pool.register_plugin() and apphook_pool.register() as decorators in examples. (django-cms#6088) * Used plugin_pool.register_plugin() as decorator in examples. plugin_pool.register_plugin() can be used as decorator since ac62acd. * Used apphook_pool.register() as decorator in examples. apphook_pool.register() can be used as decorator since 07e2b2e. * Improved/corrected various notes in the documentation * Added notes on placeholder & cms_toolbar tags Fixes django-cms#5967 * Added note on show_menu namespace parameter Fixes django-cms#5880 * Removed incorrect note from navigation docs Fixes django-cms#5738 * Fixed a bug where plugin rendered multiple times won't be editable This covers more cases then the one that was already in place Ref: django-cms#6012 * Fixed django-cms#6104 -- Set namespace to null when its apphook is removed (django-cms#6105) * Fixed a bug with empty clipboard data throwing an error when update happens on other tab * Updated sitemap.rst - Django 1.10 no longer specify views as a string (django-cms#6087) * Removed broken downloads badge (django-cms#6095) * Synced CHANGELOG with 3.4.x * Fixed django-cms#6045 -- Validate IP address on toolbar IP check (django-cms#6046) * Adjusted stacklevel for CMSPlugin.page warning. (django-cms#6099) * Fixed formatting in How to extend the Toolbar docs (django-cms#6096) * Refs django-cms#6083 -- Fixed PageUserGroup manager deprecation warning. (django-cms#6111) * Fixed a bug where unnecessary handlers were attached to render_model_block's * Fixed a bug with rendering button groups * Updated required node version in docs [ci only docs] * Fixed "Expand all / Collapse all" not reflecting real state of the tree * Fixed unnecessary handlers attached to render models Fix in 644c04a was incorrect. * Fixed JS error happening when localstorage was cleared * Refacted page tree into page nodes (django-cms#6112) Added support for pages shared accross multiple sites * Frontend for shared pages (django-cms#6129) * Fixed django-cms#6130 -- Set overwrite_url initial value on advanced settings form (django-cms#6132) * Fixed django-cms#6131 -- Pages can be copied into any position in the page tree (django-cms#6133) * Moved is_page_type declaration to proper migration * Don't use site as a lookup on template tags * Fixed TypeError * Fixed django-cms#6135 -- Only show overwrite url if the overwrite flag is set (django-cms#6136) * Users should be able to see unpublished shared pages * Fixed django-cms#6137 -- Don't add "-copy" when using existing slugs on pages in wizard (django-cms#6138) * Fixed django-cms#6139 -- Check only for add and view permissions on page copy (django-cms#6140) * Set "pending" pages as unpublished * Shared pages can't be edited but can be previewed * Fixed django-cms#6141 -- Copy plugins for each translation of page (django-cms#6142) * Fixed django-cms#6144 -- Always append slug prefix when using existing slug in wizard (django-cms#6145) * Fixed django-cms#6143 -- Add -copy to the slug and path if copied page has conflicting slug (django-cms#6146) * Fixed django-cms#6147 -- Show pages in PageField only once, regardless of translations count (django-cms#6148) * Fixed django-cms#6149 -- Don't render aliased plugins/placeholders if the host page is unpublished (django-cms#6150) * Fixed django-cms#6151 -- Pages can be copied as the first child of a parent page (django-cms#6152) * Fixed a bug when adding multiple plugins The structure returned into the dataBridge when adding the plugin was ordered `parent -> child + child` but the frontend expects it to be `child + child -> parent` because if the plugin doesn't have it's own markup - the data about the child and parent is added to the same node and the first one initialized must be the innermost one. * Added multi-wrap plugin * Added integration test for adding multiple plugins and correct tooltip * Use correct db-alias on page nodes migratio F438 n * Fixed a bug when page nodes wont open when children were added * Fixed a bug where static placeholders wont be togglable after page edits * Only the PageAdmin can register plugin urls * Fixed a bug with focusing inputs inside a modal in IE * Fixed django-cms#6158 -- Don't show unpublished pages in the menu. (django-cms#6159) * Added more detailed __repr__ to Wizard base class * Adjust page wizard tests * Added a check for version mismatch in the localStorage * Added a timeout in the integration test to avoid db lock on travis Ref: https://travis-ci.org/divio/django-cms/jobs/311394078 * Fixed invalid urls generated from toolbar on page-types * Fixed django-cms#6165 -- Don't leak context to aliased plugins (django-cms#6166) * Added target language to plugin endpoints * Removed plugin language * Removed plugin_language and page_language GET params from BE * Fixed django-cms#6171 -- Always fallback to a configured site language on the page admin (django-cms#6174) * Fixed a bug with detecting added plugin * Fixed django-cms#5952 -- Set touch='selected' in jstree.dnd config. See https://www.jstree.com/api/#/?f=$.jstree.defaults.dnd.touch Conflicts: cms/static/cms/js/dist/3.4.5/bundle.admin.pagetree.min.js cms/static/cms/js/dist/3.4.5/bundle.toolbar.min.js * Refactored the fallbacks handling logic (django-cms#6182) * Use Django's language override (django-cms#6187) * Fixes django-cms#6189 -- Use only published languages when rendering LanguageChanger for public page (django-cms#6190) * Fixed django-cms#6188 -- Only set published (or once published) languages into the public page (django-cms#6191) * Fixed django-cms#6192 -- Filter out pages in the menu based on supported user languages (django-cms#6193) * Made "View on site" links close the sideframe * Fixed a bug where welcome page would not respect the toolbar language * Prevented scrolling of the parent when structureboard is open * Added a regression test for django-cms#6162 * Fixed a bug with random collapsing of moved plugins * Fixed a couple of rare clipboard bugs * Improved documentation for Wizard classes. * Removed / updated outdated deprecation notes in docs. (django-cms#6128) * Refactored modal event system to be consistent * Fixed loader causing circular dependency between Toolbar and rest of the js modules * Cleaned up the code for refreshing plugins and fixed missing translation * Fixed django-cms#6199 -- Show all languages on language chooser if user is staff (django-cms#6200) * Added page copying across sites * Added frontend changes required for copying across sites * Fixed a rare bug with widgets not initializing correctly * Fixed django-cms#6201 -- Don't allow users to paste a page if it doesn't have translations for current site * Added a handler for bad request response in the pagetree * Fixed django-cms#6205 -- Require "Change advanced settings" permission to change template (django-cms#6206) * Fixed django-cms#6178 -- Keep placeholder declaration order when using block tags (django-cms#6208) * Fixed django-cms#6213 -- Display aliased content on edit mode regardless of source page status (django-cms#6212) * Refs django-cms#6083 -- Added on_delete for all ForeignKeys and OneToOneFields (django-cms#6108) * Removed deprecated code for 3.5 release (django-cms#6215) Summary: * Renamed menu to menus module * Removed django_load module in favor of django builtin helpers * Removed support for django-reversion * urls and menus attributes are no longer supported on apphook classes * Removed old wizard settings * Refactored PageNode into TreeNode (django-cms#6217) * Fixed the way version check is made in settings * Renamed set_homepage to set_as_homepage (classmethod to method) (django-cms#6218) Also changed the default page cache prefix * Added backwards compatible shims for parent and site fields * Removed usages of site_id and parent_id * Fixed django-cms#6222 -- Shortcircuit page wizard form validation if there's errors (django-cms#6223) * Fixed django-cms#6220 -- Show descendant pages in the delete confirmation page (django-cms#6221) * Fixed django-cms#6225 -- Added get_root method to Page model (django-cms#6226) * Created release notes for django CMS 3.5 [skip-ci] * Release notes updated on the basis of feedback [ci-skip] * Corrected release notes (django-cms#6230) [ci only docs] * Fixed django-cms#6231 -- Pages created under a page-type page should also be page types (django-cms#6232) * Fixed a visual inconsistency between condensed and expanded structureboard * Fixed a rare bug with some plugins expand state not being remembered * Added 'how to upgrade' section to release notes (django-cms#6234) [ci only docs] * Release 3.5.0rc1 (django-cms#6235) * Updated AUTHORS file * Updated po files * Updated mo files * Updated css, icon and font files * Bumped version to 3.5.0rc1 * Removed "View on site" button when adding page * Fixed a bug add plugin placeholder position not being updated on external actions * Fixed django-cms#5070 -- Welcome page no longer uses multilingual URLs when not required (django-cms#6239) * Added some tests from the content / structure split (django-cms#6244) * Fixed django-cms#6245 -- Sitemap should only show public languages (django-cms#6247) * Fixed django-cms#6196 -- Prevent users from passing a public page as parent in create_page api function (django-cms#6126) * Added new project guide to release notes (django-cms#6236) * Noted apphook-related deprecations in release notes (django-cms#6252) [ci only docs] * Release 3.5.0 (django-cms#6253) * Updated CHANGELOG * Updated po files * Updated mo files * Updated css, icon and font files * Bumped version to 3.5.0 * Disabled spelling in documentation (django-cms#6257) Removed sphinxcontrib-spelling from docs/requirements.txt, as it was causing build errors on Read the Docs. This will need to be reinstated in due course. * Fixed django-cms#6035 -- Don't alter the AdvancedSettingsForm form data (django-cms#6250) * Fixed django-cms#6227 -- Migrations should only depend on initial content type migration (django-cms#6260) * Add stacklevel to Page attribute warnings (django-cms#6263) * Added CHANGELOG entry for 3.5.1 * Fixed django-cms#6267 -- Migration 0017 should handle multiple page type roots (one per site) (django-cms#6269) * Fixed django-cms#6266 -- Added missing migration operation (django-cms#6268) * Fixed a bug when toolbar js is rendered before toolbar (django-cms#6270) * Added frontend integration topic (django-cms#6276) * Fixed a bug when CMS would incorrectly highlight plugin content Invisible elements were reporting 0/0 offset which would essentially scroll the page higher and higher every time you press shift while hovering over plugin that has invisible elements * Release 3.5.1rc1 (django-cms#6286) * Updated css, icon and font files * Bumped version to 3.5.1rc1 * Updated compatibility table (django-cms#6275) * Updated license year (django-cms#6264) * Fixed django-cms#6289 -- Don't fail silently on templates with variable extends (django-cms#6291) * Release 3.5.1rc2 (django-cms#6292) * Updated css, icon and font files * Bumped version to 3.5.1rc2 * Fixed django-cms#6296 -- Removed localization for pk values in toolbar js (django-cms#6294) * Release 3.5.1 (django-cms#6297) * Updated css, icon and font files * Added release notes for 3.5.1 * Bumped version to 3.5.1 * Fixed a bug with shortcuts modal not opening after toolbar reload * Fix sideframe race condition * Fixed django-cms#6307 -- Don't add a leading / character to url paths (django-cms#6311) This only affected moving / publishing the homepage. * Updated pull request template (for documentation) (django-cms#6211) [ci-skip] * Fixed a bug where non-staff user would be able to open empty structure board * Removed references to admin/img/icon_addlink.gif file (django-cms#6319) Use add-another CSS class which provides the icon in Django 1.8 - 1.11 * Added docs theme * Updated Makefile * Renamed limit_menu_visibility parameter (django-cms#6304) Renamed limit_menu_visibility to limit_visibility_in_menu * Fixed django-cms#6280 -- Split migration 0018 into three separate migration files (django-cms#6322) * Clarified apphook documentations (django-cms#6318) [ci only docs] * Improved static placeholder documentation (django-cms#6315) [ci only docs] * Release 3.5.2rc1 (django-cms#6327) * Added 3.5.2 release notes * Updated css, icon and font files * Bumped version to 3.5.2rc1 * Show Divio cloud banner in the docs [ci skip] * Release 3.5.2 (django-cms#6331) * Updated css, icon and font files * Bumped version to 3.5.2 * Use toolbar.request_language instead of deprecated toolbar.language * Use toolbar.request_language instead of deprecated toolbar.language part 2 * Added 3.6 CHANGELOG * Removed backwards compatible shims from 3.5 * Removed the cms moderator command * Dropped support for Django < 1.11 * Removed the translatable content get / set methods from CMSPlugin model * Removed signal handlers for Page, Title, Placeholder and CMSPlugin models * Updated links to contributing docs * Fixed django-cms#6340 -- Reorder models to support dumpdata (django-cms#6341) * Fixed django-cms#6336 -- request.current_page should always respect draft/live state (django-cms#6350) * Refs django-cms#6185 -- Moved meta description length restriction from model to form (django-cms#6362) Increased meta description length restriction to 320 characters * Fixed django-cms#6353 -- Removed extra quotation mark from button sideframe template (django-cms#6364) * Fixed django-cms#6002 -- Prevent users from moving homepage under another page (django-cms#6369) * Updated links in README to use https where possible (django-cms#6375) Fixed outdated links to documentation pages * Fixed a bug where structureboard tried to preload markup with legacy renderer * Fixed a bug with incorrect move plugin handling * Fixed some spelling and build issues (django-cms#6391) * Fixes/improves introductory tutorial (django-cms#6390) * introduces numbering of sections * fixes django-cms#6359 * Cleaned up apphooks documentation (django-cms#6397) * fixes django-cms#6377 [ci only docs] * Improved toolbar tutorial (django-cms#6400) * Improved toolbar tutorial * Docs tutorials small fixes (django-cms#6405) * Fixed typo * Improved URLs explanation * Update 03-integrating_applications.rst * Docs tutorials small fixes (django-cms#6408) * Made minor improvements to tutorial * Fixed django-cms#6346 -- Set xframe options exempt on cached response (django-cms#6403) * Fixed django-cms#6335 -- Global permissions take precedence over cached page permissions (django-cms#6411) * Update apphooks.rst (django-cms#6255) * Update apphooks.rst You need to add *Application instance name* by hand to a page when you add an ``app_name`` #hopeitsavessomeoneelsethetrouble * Changed as per czpython's suggestions While still trying to convey that we're fixing the same problem than the previous paragraphs refers to (and that *Application instance name* only appears after setting ``app_name`` ) * Added page_title parameter to create_page API function(django-cms#6122) * Fixed a bug with not enabling plugins that are not rendered in content * Updated apphooks (how-to and introduction) (django-cms#6409) * Updated apphooks how-to and introduction [ci only docs] * Fixed a bug with expanding static placeholder by clicking on "Expand All" button * Introduced Django 2.0 & 2.1 support (django-cms#6402) * Rewrote how-to guide and reference for the toolbar (django-cms#6427) * Rewrote how-to guide and reference for the toolbar * How-to guide makes best practice clearer. * Numerous private APIs are no longer mentioned. * Removed out-of-date comment re request-hook * Improved how-to guides index page (django-cms#6464) [ci only docs] * Fixed django-cms#6383 -- Rewriting url of page corrupted after save basic settings of page (django-cms#6470) * Fixed django-cms#6083 -- Make on_delete configurable (django-cms#6487) * Upgraded test dependency Pillow (django-cms#6524) * Fixed django-cms#6340 -- Don't handle signals sent on fixture load (django-cms#6473) * Fixed a bug with deleting a model from changelist inside modal * Updated core team and version support details (django-cms#6555) (django-cms#6556) * Bumped version to 3.6.0rc1 (django-cms#6559) * Added documentation for cms 3.6.0 and 3.5.3 (django-cms#6575) * Added 3.5.3 release notes * Added documentation for cms 3.6.0 * Updated contributors * Updated AUTHORS * Release 3.6.0rc1 (django-cms#6576) * Fixed spelling errors * Fixed broken documentation references * Updated release notes * Improved menu logic description Flattened the deeply-nested list by breaking it apart into logical sections. This will remedy issues in the PDF version of the documentation, which failed to handle the list well. * Issue django-cms#6342: docs of `text_enabled` Issue django-cms#6342: Extended the docs of `text_enabled` param for plugins * Fixed django-cms#6585 -- Added missing clear cache for menu when page is created (django-cms#6584) * Fixed django-cms#6572 -- Added missing clear cache for menu when page moved (django-cms#6590) * Release 3.6.0rc2 (django-cms#6591) * Fixed django-cms#6595 -- missing clear cache for a menu after copied page (django-cms#6596) * Add clear cache for copy page form * Removed fixes for menu cache from changelog * Release 3.6.0rc3 (django-cms#6598) * Release 3.6.0rc3 * Update translations * Release 3.6.0 (django-cms#6604) * Fixed django-cms#6457 -- Fixed rendering of permission icons (django-cms#6624) * use SVG icons * add compatibility layer for Django-1.8 * Fixed travis matrix by moving menu test to allow_failures section (django-cms#6628) * Moved test menu for python 2.7 to allow_failures section (django-cms#6625) * Removed fast finish * Add to include * Restore fast_finish * Fixed a bug with top-level object/embed/applet tags (django-cms#6497) * Fix wrong field name (django-cms#6467) `extended_page` is not a field of a `PageExtension`. This should be `extended_object`. * Fixed django-cms#6440 -- render_plugin_block template tag (django-cms#6472) * - Fixes django-cms#6440 - `render_plugin_block` template tag - removes unnecessary template - updates changelog * adapted changelog * Update install.rst (django-cms#6610) change MIDDLEWARE_CLASSES to MIDDLEWARE as cms check expects * Fix typo in documentation (django-cms#6612) - Fix typo in apphooks section of introduction docs - Fix typo in index of introduction * Update install documentation to use re_path (django-cms#6613) * Update install documentation to use re_path The example with url(...) no longer works. The correct syntax is re_path(...). * Changed documentation to based on feedback from Bartosz Płóciennik The change to use re_path is only necessary when using Django 2.0. Reverted the change and added a note for Django 2.0 users. * Page has no attribute site_id [Docs] (django-cms#6614) * plugin_instance.position = new_plugin.position in CMSPlugin.copy_plugin fix null position in copy_plugin method. CMSPlugin position not null + default = 0 * CMSplugin.position not null Django CMSPlugin.position null raises unorderable types: NoneType() < int() * fixed page has not attribute site_id * Update copyright year in docs to be dynamic (django-cms#6618) * typo: added spaces on configuration docs (django-cms#6330) * Fixed django-cms#6615 -- Removed depreciation warnings for imp package (django-cms#6637) * Removed depreciation warnings for imp package * Change try except * Restored Django flags in compat file (django-cms#6636) * Add missing parenthesis in code (django-cms#6677) * Adding support for Django 2.2 LTS (django-cms#6655) * New changes for cms 3.7 * Fix typo * Fixed issue with force_color * Removed unused import * Added docs to index.rst * Fixed travis jobs * Fixed force_color command * Changes after review * Fixed django version in setup * Update django-2.2.txt * Fixes test suite (django-cms#6688) * add information for testing * fix tests * updated CHANGELOG * update * 1.8.5 * fix tests locally * update text * Adapt test suite for recent Travis changes (django-cms#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) * Fix content mode related to django-cms#6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (django-cms#6673) * Add missing template context processor to self install docs Fixes django-cms#5828 * Reword self install docs for clarity * Add to AUTHORS file * Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase (django-cms#6667) * Add 'prepopulated_fields' to ignore list Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin) * Update AUTHORS * Override urlconf_module so that Django system checks don't crash. (django-cms#6719) * Add a test case for django-cms#6717. * Override urlconf_module so that Django system checks don't crash. Without this fix, Django system checks in Django 2.2 will try to resolve the "app_resolver" module, which does not exist. Overriding ``urlconf_module`` prevents the issue. Fixes django-cms#6717 * Backport 3.7.0 release to develop (django-cms#6736) * Add missing parenthesis in code (django-cms#6677) (django-cms#6690) * Adding support for Django 2.2 LTS (django-cms#6655) (django-cms#6691) * New changes for cms 3.7 * Fix typo * Fixed issue with force_color * Removed unused import * Added docs to index.rst * Fixed travis jobs * Fixed force_color command * Changes after review * Fixed django version in setup * Update django-2.2.txt * Fixes test suite (django-cms#6688) (django-cms#6692) * add information for testing * fix tests * updated CHANGELOG * update * 1.8.5 * fix tests locally * update text * Release 3.7.0a1 (internal) (django-cms#6693) * bumped version to 3.7.0a1 * updated staticfiles * updated translations * Adapt test suite for recent Travis changes (django-cms#6709) (django-cms#6710) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) (django-cms#6711) * Adapt test suite for recent Travis changes (django-cms#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) * Fix content mode related to django-cms#6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (django-cms#6673) (django-cms#6712) * Adapt test suite for recent Travis changes (django-cms#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) * Fix content mode related to django-cms#6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (django-cms#6673) * Add missing template context processor to self install docs Fixes django-cms#5828 * Reword self install docs for clarity * Add to AUTHORS file * Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase (django-cms#6667) (django-cms#6713) * Add 'prepopulated_fields' to ignore list Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin) * Update AUTHORS * Release 3.7.0rc1 (django-cms#6715) * update django version in sphinx * bumped version * updated existing translations * update static files * update docs * update authors file * Override urlconf_module so that Django system checks don't crash. (django-cms#6719) (django-cms#6723) * Add a test case for django-cms#6717. * Override urlconf_module so that Django system checks don't crash. Without this fix, Django system checks in Django 2.2 will try to resolve the "app_resolver" module, which does not exist. Overriding ``urlconf_module`` prevents the issue. Fixes django-cms#6717 * Release 3.7.0rc2 (django-cms#6724) * regenerated translation files * bumped version * update existing translation * compile static files * updated release notes * Updated compatibility table (django-cms#6727) * Release 3.7.0 (django-cms#6735) * Bumped version to 3.7.0 * updated translation files * added static files * Improved and simplified permissions documentation (django-cms#6224) [ci-skip] * Updated branch policy (django-cms#6320) * Updated branch policy [ci only docs] * Removed feature branch notes from policy * Improve apphooks documentation (django-cms#6743) Remove a reference to `urls` attribute on AppHook class in the documentation. * Fix documentation bug regarding CMSPluginBase (django-cms#6744) The documentation advertises that you can set the module attribute of custom plugins to None. If the user attempts this django they won't be able to start up when django.contrib.admin.site.urls is included in urls.py (tested with django 1.11.25 and django-cms 3.7.0). * Added example of `get_plugin_instance` to the docs on nested plugins. (django-cms#6609) * Amend Changelog and fixes from merged PRs (django-cms#6755) * add missing changelog entries * update docs * updated changelog * updates from comments * Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (django-cms#6679) * Pass site object instead of pk when rendering menu Add original fix by @saqlainsyed007 * Moved test to it's own class * Update changelog * Do not let non-staff users to log in via CMS Toolbar (django-cms#6705) * Merged stale PR's (django-cms#6759) * add missing changelog entries * update docs * updated changelog * updates from comments * merge django-cms#6347 * merged django-cms#6530 * merge django-cms#6538 * merge django-cms#6549 * merge django-cms#6704 * changelog for django-cms#6705 * Update issue templates * Fixed django-cms#6737 -- Fix 'urls.W001' warning with custom apphook urls (django-cms#6738) * Refs django-cms#6737 -- Add test for apphooks urls config check * Fixed django-cms#6737 -- Fix 'urls.W001' warning with custom apphook urls When rewriting the apphooks urls in appresolver.recurse_patterns, the original RegexPattern.is_endpoint flag is lost, so urls with a callback view throws an "include with a route ending with a '$'" warning ('urls.W001'). @apphook_pool.register class MyApp(CMSApp): name = "MyApp" def get_urls(self, page=None, language=None, **kwargs): return [ re_path(r"^$", views.MyAppView.as_view(), name="my-app-index") # or this # path(r"", views.MyAppView.as_view(), name="my-app-index") ] $ ./manage.py check System check identified some issues: WARNINGS: ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs. This fix set the RegexPattern flag is_endpoint to True for callback views in appresolver.recurse_patterns as in https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70 * Updated documentation and files for 3.7 LTS (django-cms#6761) * general updates * updates from comments * update form comments * Fix simple typo: seperated -> separated (django-cms#6767) * Fix simple typo: seperated -> separated * Update CHANGELOG.rst * Update djangocms installer docs (django-cms#6764) * Backport 3.7.1 release to develop (django-cms#6773) * Add missing parenthesis in code (django-cms#6677) (django-cms#6690) * Adding support for Django 2.2 LTS (django-cms#6655) (django-cms#6691) * New changes for cms 3.7 * Fix typo * Fixed issue with force_color * Removed unused import * Added docs to index.rst * Fixed travis jobs * Fixed force_color command * Changes after review * Fixed django version in setup * Update django-2.2.txt * Fixes test suite (django-cms#6688) (django-cms#6692) * add information for testing * fix tests * updated CHANGELOG * update * 1.8.5 * fix tests locally * update text * Release 3.7.0a1 (internal) (django-cms#6693) * bumped version to 3.7.0a1 * updated staticfiles * updated translations * Adapt test suite for recent Travis changes (django-cms#6709) (django-cms#6710) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) (django-cms#6711) * Adapt test suite for recent Travis changes (django-cms#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) * Fix content mode related to django-cms#6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (django-cms#6673) (django-cms#6712) * Adapt test suite for recent Travis changes (django-cms#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to django-cms#6694 (django-cms#6696) * Fix content mode related to django-cms#6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (django-cms#6673) * Add missing template context processor to self install docs Fixes django-cms#5828 * Reword self install docs for clarity * Add to AUTHORS file * Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase (django-cms#6667) (django-cms#6713) * Add 'prepopulated_fields' to ignore list Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin) * Update AUTHORS * Release 3.7.0rc1 (django-cms#6715) * update django version in sphinx * bumped version * updated existing translations * update static files * update docs * update authors file * Override urlconf_module so that Django system checks don't crash. (django-cms#6719) (django-cms#6723) * Add a test case for django-cms#6717. * Override urlconf_module so that Django system checks don't crash. Without this fix, Django system checks in Django 2.2 will try to resolve the "app_resolver" module, which does not exist. Overriding ``urlconf_module`` prevents the issue. Fixes django-cms#6717 * Release 3.7.0rc2 (django-cms#6724) * regenerated translation files * bumped version * update existing translation * compile static files * updated release notes * Updated compatibility table (django-cms#6727) * Release 3.7.0 (django-cms#6735) * Bumped version to 3.7.0 * updated translation files * added static files * Backport to prepare for 3.7.1 (django-cms#6762) * Improved and simplified permissions documentation (django-cms#6224) [ci-skip] * Updated branch policy (django-cms#6320) * Updated branch policy [ci only docs] * Removed feature branch notes from policy * Improve apphooks documentation (django-cms#6743 F987 ) Remove a reference to `urls` attribute on AppHook class in the documentation. * Fix documentation bug regarding CMSPluginBase (django-cms#6744) The documentation advertises that you can set the module attribute of custom plugins to None. If the user attempts this django they won't be able to start up when django.contrib.admin.site.urls is included in urls.py (tested with django 1.11.25 and django-cms 3.7.0). * Added example of `get_plugin_instance` to the docs on nested plugins. (django-cms#6609) * Amend Changelog and fixes from merged PRs (django-cms#6755) * add missing changelog entries * update docs * updated changelog * updates from comments * Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (django-cms#6679) * Pass site object instead of pk when rendering menu Add original fix by @saqlainsyed007 * Moved test to it's own class * Update changelog * Do not let non-staff users to log in via CMS Toolbar (django-cms#6705) * Merged stale PR's (django-cms#6759) * add missing changelog entries * update docs * updated changelog * updates from comments * merge django-cms#6347 * merged django-cms#6530 * merge django-cms#6538 * merge django-cms#6549 * merge django-cms#6704 * changelog for django-cms#6705 * Update issue templates * Fixed django-cms#6737 -- Fix 'urls.W001' warning with custom apphook urls (django-cms#6738) * Refs django-cms#6737 -- Add test for apphooks urls config check * Fixed django-cms#6737 -- Fix 'urls.W001' warning with custom apphook urls When rewriting the apphooks urls in appresolver.recurse_patterns, the original RegexPattern.is_endpoint flag is lost, so urls with a callback view throws an "include with a route ending with a '$'" warning ('urls.W001'). @apphook_pool.register class MyApp(CMSApp): name = "MyApp" def get_urls(self, page=None, language=None, **kwargs): return [ re_path(r"^$", views.MyAppView.as_view(), name="my-app-index") # or this # path(r"", views.MyAppView.as_view(), name="my-app-index") ] $ ./manage.py check System check identified some issues: WARNINGS: ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs. This fix set the RegexPattern flag is_endpoint to True for callback views in appresolver.recurse_patterns as in https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70 * Updated documentation and files for 3.7 LTS (django-cms#6761) * general updates * updates from comments * update form comments * Further backports for 3.7.1 (django-cms#6768) * add newly generated strings * Fix simple typo: seperated -> separated (django-cms#6767) * Fix simple typo: seperated -> separated * Update CHANGELOG.rst * Update djangocms installer docs (django-cms#6764) * Release django CMS 3.7.1 (django-cms#6769) * update documentation * Bumped version to 3.7.1 * compiled available languages * update static files * fix build * bump date * rebundle * Minor typo Corrections in custom_plugins.rst (django-cms#6789) * Djangocmstutorial (django-cms#6804) * Minor typo Corrections in custom_plugins.rst * Corrections or updates with the current Django CMS * correction reverted to original * Improved plugins documentation Co-authored-by: Paulo <commonzenpython@gmail.com> Co-authored-by: Daniele Procida <daniele@vurt.org> Co-authored-by: Ludwig Hähne <lhaehne@gmail.com> Co-authored-by: Vadim Sikora <vadim.sikora@divio.ch> Co-authored-by: Júlio R. Lucchese <julio2786@gmail.com> Co-authored-by: Gianluca Guarini <gianluca.guarini@gmail.com> Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com> Co-authored-by: Nicolas PASCAL <np.pascal@gmail.com> Co-authored-by: Salmanul Farzy <salmanulfarzy@gmail.com> Co-authored-by: Andras Gyömrey <lgandras@gmail.com> Co-authored-by: Tim Graham <timograham@gmail.com> Co-authored-by: Mark Walker <mark.walker@therealbuzzgroup.com> Co-authored-by: Filipe Waitman <filwaitman@gmail.com> Co-authored-by: André Cruz <andre@cabine.org> Co-authored-by: Jens Diemer <github.com@jensdiemer.de> Co-authored-by: Laurens Bosscher <laurens@laurensbosscher.nl> Co-authored-by: Joseph Lin <josephlin55555@gmail.com> Co-authored-by: René Fleschenberg <rene@fleschenberg.net> Co-authored-by: Stefan Wehrmeyer <stefanw@users.noreply.github.com> Co-authored-by: Aidas Bendoraitis <aidasbend@yahoo.com> Co-authored-by: heppstux <hello@stephanhepper.com> Co-authored-by: Krzysztof Socha <ksocha@ksocha.com> Co-authored-by: Frank <akura11.tt@gmail.com> Co-authored-by: Aliaksei Urbanski <mimworkmail@gmail.com> Co-authored-by: Chematronix <6773039+Chematronix@users.noreply.github.com> Co-authored-by: Mateusz Kamycki <mateusz.kamycki@gmail.com> Co-authored-by: Julz <julius.schindler@wirsindmedia.de> Co-authored-by: Katie McLaughlin <katie@glasnt.com> Co-authored-by: Jacob Rief <jacob.rief@gmail.com> Co-authored-by: Bartosz Płóciennik <vThaian@users.noreply.github.com> Co-authored-by: Jeroen <mail@jeroenpeters.com> Co-authored-by: schwobaseggl <rueckert@hm.edu> Co-authored-by: Robert Stein <SteinRobert@users.noreply.github.com> Co-authored-by: Sascha Marcel Schmidt <torvitas@users.noreply.github.com> Co-authored-by: Gourav Chawla(dotgourav) <gouravchawla@live.com> Co-authored-by: mobilepattern <russell@mobilepattern.com> Co-authored-by: Paweł <pm4public@gmail.com> Co-authored-by: Baptiste Darthenay <baptiste.darthenay@gmail.com> Co-authored-by: Craig Anderson <craiga@craiga.id.au> Co-authored-by: Angelo Dini <angelo.dini@divio.ch> Co-authored-by: Dmytro Litvinov <litvinov.dmytro.it@gmail.com> Co-authored-by: Christy O'Reilly <christyor73@gmail.com> Co-authored-by: Louis-Dominique Dubeau <ldd@lddubeau.com> Co-authored-by: Adrien Delhorme <adrien.delhorme@gmail.com> Co-authored-by: Sebastian Jordan <sebastian.jordan.mail@googlemail.com> Co-authored-by: Stephan Michaud <michauds90@gmail.com> Co-authored-by: Sergey Gusev <andrschwartz@gmail.com> Co-authored-by: Raffaele Salmaso <raffaele.salmaso@gmail.com> Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Iacopo Spalletti <i.spalletti@nephila.digital> Co-authored-by: Meb <58698531+mebdivio@users.noreply.github.com>
FinalAngel
added a commit
that referenced
this pull request
Jul 21, 2020
* Add missing parenthesis in code (#6677) (#6690) * Adding support for Django 2.2 LTS (#6655) (#6691) * New changes for cms 3.7 * Fix typo * Fixed issue with force_color * Removed unused import * Added docs to index.rst * Fixed travis jobs * Fixed force_color command * Changes after review * Fixed django version in setup * Update django-2.2.txt * Fixes test suite (#6688) (#6692) * add information for testing * fix tests * updated CHANGELOG * update * 1.8.5 * fix tests locally * update text * Release 3.7.0a1 (internal) (#6693) * bumped version to 3.7.0a1 * updated staticfiles * updated translations * Adapt test suite for recent Travis changes (#6709) (#6710) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to #6694 (#6696) (#6711) * Adapt test suite for recent Travis changes (#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to #6694 (#6696) * Fix content mode related to #6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (#6673) (#6712) * Adapt test suite for recent Travis changes (#6709) * test something * further updates and add 3.7 to test * updates * simplify for tests * add 3.7 support * Fix content mode related to #6694 (#6696) * Fix content mode related to #6694 * Add Dmytro Litvinov to AUTHORS according to PR template * Self install doc tweaks (#6673) * Add missing template context processor to self install docs Fixes #5828 * Reword self install docs for clarity * Add to AUTHORS file * Documenation: Add 'prepopulated_fields' to ignored options list on CMSPluginBase (#6667) (#6713) * Add 'prepopulated_fields' to ignore list Added `prepopulated_fields` to the list of options that will be ignored when creating a custom DjangoCMS plugin with CMSPluginBase (which is based on ModelAdmin) * Update AUTHORS * Release 3.7.0rc1 (#6715) * update django version in sphinx * bumped version * updated existing translations * update static files * update docs * update authors file * Override urlconf_module so that Django system checks don't crash. (#6719) (#6723) * Add a test case for #6717. * Override urlconf_module so that Django system checks don't crash. Without this fix, Django system checks in Django 2.2 will try to resolve the "app_resolver" module, which does not exist. Overriding ``urlconf_module`` prevents the issue. Fixes #6717 * Release 3.7.0rc2 (#6724) * regenerated translation files * bumped version * update existing translation * compile static files * updated release notes * Updated compatibility table (#6727) * Release 3.7.0 (#6735) * Bumped version to 3.7.0 * updated translation files * added static files * Backport to prepare for 3.7.1 (#6762) * Improved and simplified permissions documentation (#6224) [ci-skip] * Updated branch policy (#6320) * Updated branch policy [ci only docs] * Removed feature branch notes from policy * Improve apphooks documentation (#6743) Remove a reference to `urls` attribute on AppHook class in the documentation. * Fix documentation bug regarding CMSPluginBase (#6744) The documentation advertises that you can set the module attribute of custom plugins to None. If the user attempts this django they won't be able to start up when django.contrib.admin.site.urls is included in urls.py (tested with django 1.11.25 and django-cms 3.7.0). * Added example of `get_plugin_instance` to the docs on nested plugins. (#6609) * Amend Changelog and fixes from merged PRs (#6755) * add missing changelog entries * update docs * updated changelog * updates from comments * Sites - Pass Site obj instead of pk when creating a StaticPlaceholder (#6679) * Pass site object instead of pk when rendering menu Add original fix by @saqlainsyed007 * Moved test to it's own class * Update changelog * Do not let non-staff users to log in via CMS Toolbar (#6705) * Merged stale PR's (#6759) * add missing changelog entries * update docs * updated changelog * updates from comments * merge #6347 * merged #6530 * merge #6538 * merge #6549 * merge #6704 * changelog for #6705 * Update issue templates * Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls (#6738) * Refs #6737 -- Add test for apphooks urls config check * Fixed #6737 -- Fix 'urls.W001' warning with custom apphook urls When rewriting the apphooks urls in appresolver.recurse_patterns, the original RegexPattern.is_endpoint flag is lost, so urls with a callback view throws an "include with a route ending with a '$'" warning ('urls.W001'). @apphook_pool.register class MyApp(CMSApp): name = "MyApp" def get_urls(self, page=None, language=None, **kwargs): return [ re_path(r"^$", views.MyAppView.as_view(), name="my-app-index") # or this # path(r"", views.MyAppView.as_view(), name="my-app-index") ] $ ./manage.py check System check identified some issues: WARNINGS: ?: (urls.W001) Your URL pattern '^my-app-url/my-view-url/$' [name='my-app-index'] uses include with a route ending with a '$'. Remove the dollar from the route to avoid problems including URLs. This fix set the RegexPattern flag is_endpoint to True for callback views in appresolver.recurse_patterns as in https://github.com/django/django/blob/stable/2.2.x/django/urls/conf.py#L70 * Updated documentation and files for 3.7 LTS (#6761) * general updates * updates from comments * update form comments * Further backports for 3.7.1 (#6768) * add newly generated strings * Fix simple typo: seperated -> separated (#6767) * Fix simple typo: seperated -> separated * Update CHANGELOG.rst * Update djangocms installer docs (#6764) * Release django CMS 3.7.1 (#6769) * update documentation * Bumped version to 3.7.1 * compiled available languages * update static files * fix build * bump date * Update 04-plugins.rst (#6782) Migration does not work without on_delete on a ForeignKey-Field * Backport changes to 3.7.x (#6837) * Add Django 3 and Python 3.8 support (#6796) * release version lock * remove python_2_unicode_compatible * migrated from ``django.utils.six`` to the six package * more migrations * update static import * update to TemplateResponse * add new arguments * re-add unicode * further adaptions * fix additional issues * update test framework * update docs * revert this change * add space * adapt upgrade docs * fix tests * test updates * easy dependency * adapt requirements files * cleanup tests * minor update * revert pyflakes * test something * another test * updates * fix some tests * tests * Usage of session to store user language has been deprecated * Fix pyflakes support * Fix on py2.7 Co-authored-by: Iacopo Spalletti <i.spalletti@nephila.it> # Conflicts: # docs/introduction/09-third_party.rst * Improved plugins documentation # Conflicts: # docs/how_to/custom_plugins.rst Co-authored-by: Daniele Procida <daniele@vurt.org> * Release 3.7.2 (#6838) * updated translations * Bumped version to 3.7.2 * update existing translations * rebuild static files * update changelog * Updated compatibility table for 3.7.2 Co-authored-by: Daniele Procida <daniele@vurt.org> * Corrected plugin documentations based on Issue #6752 (#6798) (#6858) Co-authored-by: Maximilian Konrad <maximilianlukaskonrad@hotmail.de> * Move var declaration inside closure to make it available to firefox (#6854) (#6859) # Conflicts: # CHANGELOG.rst Co-authored-by: Iacopo Spalletti <i.spalletti@nephila.digital> * Fix 3.7 on python 2 (#6855) (#6860) * Fix imports on python 2.7 * Fix requirements * Make python 2.7 required on travis * Fix url cache leak in tests * Remove references to MIDDLEWARE_CLASSES * Update changelog Co-authored-by: Iacopo Spalletti <i.spalletti@nephila.digital> * set white of first column in jstree to normal (#6856) (#6861) # Conflicts: # cms/static/cms/css/3.7.2/cms.pagetree.css Co-authored-by: Jacob Rief <jacob.rief@gmail.com> * Release 3.7.3 (#6862) * generate translations * Bumped version to 3.7.3 * compile translations * upgrade static assets * update docs * add release date * Release 3.7.4 (#6881) * add patch * bumdle * bump version * regenerate build files Co-authored-by: Daniele Procida <daniele@vurt.org> Co-authored-by: datencoach <51292314+datencoach@users.noreply.github.com> Co-authored-by: Maximilian Konrad <maximilianlukaskonrad@hotmail.de> Co-authored-by: Iacopo Spalletti <i.spalletti@nephila.digital> Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pass Site object to django db create instead of pk.
Original code caused a ValueError when defining create a site-specific static_placeholder.
Old PR here with fix: #6476
I created a new one with a test case to validate.
I was able to repro all the way back to 3.3.0.
Fixes #6675
Documentation checklist