8000 aarch + ppc64le again for 0.22 by hmaarrfk · Pull Request #113 · conda-forge/scikit-learn-feedstock · GitHub
[go: up one dir, main page]

Skip to content

aarch + ppc64le again for 0.22 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 10, 2019
Merged

aarch + ppc64le again for 0.22 #113

merged 29 commits into from
Dec 10, 2019

Conversation

hmaarrfk
Copy link
Contributor
@hmaarrfk hmaarrfk commented Dec 7, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author
hmaarrfk commented Dec 7, 2019

This is very likely ready to go. Unfortunately, I have to recommend skipping the tests for PPC64LE and AARCH64. The build time is quite variable. Sometimes, the CIs can run through the whole build + test procedure in 23 minutes, other times, it timesout after only 10% of the tests. This doesn't seem related to the test suite, since it won't even finish the build phase until 28 mins...

@hmaarrfk
Copy link
Contributor Author
hmaarrfk commented Dec 7, 2019

See odd timing failure here https://cloud.drone.io/conda-forge/scikit-learn-feedstock/36/2/2

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author
hmaarrfk commented Dec 8, 2019

finally:
image

the variance on the compilation + test times is insane.

@hmaarrfk hmaarrfk changed the title Attempt to fix aarch again for 0.22 aarch + ppc64le again for 0.22 Dec 8, 2019
@ogrisel
Copy link
Contributor
ogrisel commented Dec 9, 2019

the variance on the compilation + test times is insane.

Do you have any idea why? Noisy neighbors using the same hardware in concurrently running containers without proper cgroup quotas for CPU / disk / RAM resources maybe?

@hmaarrfk
Copy link
Contributor Author
hmaarrfk commented Dec 9, 2019

Not too sure. We can probably ping drone.

But for now. It has been passing consistently. Would you like to merge?

I the remaining failures are all legitimately issues that I reported.

Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise LGTM. Thanks @hmaarrfk !

# build the C files in parallel. This helps beat the
# time limit consistently on drone.io
- {{ PYTHON }} setup.py build_ext -j{{ CPU_COUNT }}
- {{ PYTHON }} -m pip install . -vv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep --no-deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 90 percent sure conda forge does this in their pip config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A while back, I went on this hunt, and found that they isolate the environment:
scikit-image/scikit-image#4261 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's done in conda-build, but yeah we don't need it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation!

Copy link
Member
@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hmaarrfk, this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0