-
-
Notifications
You must be signed in to change notification settings - Fork 45
aarch + ppc64le again for 0.22 #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is very likely ready to go. Unfortunately, I have to recommend skipping the tests for PPC64LE and AARCH64. The build time is quite variable. Sometimes, the CIs can run through the whole build + test procedure in 23 minutes, other times, it timesout after only 10% of the tests. This doesn't seem related to the test suite, since it won't even finish the build phase until 28 mins... |
See odd timing failure here https://cloud.drone.io/conda-forge/scikit-learn-feedstock/36/2/2 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Do you have any idea why? Noisy neighbors using the same hardware in concurrently running containers without proper cgroup quotas for CPU / disk / RAM resources maybe? |
Not too sure. We can probably ping drone. But for now. It has been passing consistently. Would you like to merge? I the remaining failures are all legitimately issues that I reported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment otherwise LGTM. Thanks @hmaarrfk !
# build the C files in parallel. This helps beat the | ||
# time limit consistently on drone.io | ||
- {{ PYTHON }} setup.py build_ext -j{{ CPU_COUNT }} | ||
- {{ PYTHON }} -m pip install . -vv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep --no-deps
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 90 percent sure conda forge does this in their pip config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A while back, I went on this hunt, and found that they isolate the environment:
scikit-image/scikit-image#4261 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's done in conda-build, but yeah we don't need it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the confirmation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hmaarrfk, this is great!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)