10000 ENH: Disable check for framework Python in OSX backend. by dopplershift · Pull Request #93 · conda-forge/matplotlib-feedstock · GitHub
[go: up one dir, main page]
Skip to content

ENH: Disable check for framework Python in OSX backend. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2016
Merged

ENH: Disable check for framework Python in OSX backend. #93

merged 1 commit into from
Dec 31, 2016

Conversation

dopplershift
Copy link
Member

Backports #92 for the devel channel.

Without this check, the osx backend can be used with just python
rather than requiring pythonw. pythonw still works better (window
comes to the front and gives a taskbar icon), but not requiring
pythonw is much less surprising to users.

Since we now work with just python, simplify the tests.

@dopplershift
ENH: Disable check for framework Python in OSX backend.
4c4ba68 
Without this check, the osx backend can be used with just `python`
rather than requiring `pythonw`. `pythonw` still works better (window
comes to the front and gives a taskbar icon), but not requiring
`pythonw` is much less surprising to users.

Since we now work with just python, simplify the tests.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The recipe license should not include the word "License".

@ocefpaf ocefpaf mentioned this pull request Dec 31, 2016
Closed
@ocefpaf
Copy link
Member
ocefpaf commented Dec 31, 2016

AppVeyor failure has nothing to do with this change. So let's merge it and get OS X working again.

@ocefpaf ocefpaf merged commit bb64d51 into conda-forge:devel Dec 31, 2016
@dopplershift dopplershift deleted the disable-check branch January 2, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dopplershift @conda-forge-linter @ocefpaf
0