8000 ENH: Disable check for framework Python in OSX backend. by dopplershift · Pull Request #92 · conda-forge/matplotlib-feedstock · GitHub
[go: up one dir, main page]

Skip to content

ENH: Disable check for framework Python in OSX backend. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2016

Conversation

dopplershift
Copy link
Member

Without this check, the osx backend can be used with just python
rather than requiring pythonw. pythonw still works better (window
comes to the front and gives a taskbar icon), but not requiring
pythonw is much less surprising to users.

Since we now work with just python, simplify the tests.

Without this check, the osx backend can be used with just `python`
rather than requiring `pythonw`. `pythonw` still works better (window
comes to the front and gives a taskbar icon), but not requiring
`pythonw` is much less surprising to users.

Since we now work with just python, simplify the tests.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The recipe license should not include the word "License".

This was referenced Dec 30, 2016
@ocefpaf ocefpaf merged commit 10a5f35 into conda-forge:master Dec 30, 2016
@ocefpaf
Copy link
Member
ocefpaf commented Dec 30, 2016

Thanks @dopplershift!

@tacaswell
Copy link
Contributor

This check went in via matplotlib/matplotlib@46f2d53 / matplotlib/matplotlib#4452 by @mdehoon .

While this may fix the behavior, but I am very concerned about going against Michiel in matters of how to deal with the OSX backend.

@dopplershift
Copy link
Member Author

For matplotlib proper, we may just want to consider adjusting our checks (or something); without the check we can still get a plot, it just doesn't have a taskbar icon nor does the window come to the front initially.

For conda-forge I think it's more important to be compatible with the defaults channel than having to explain to everyone that they need to use this weird "pythonw" thing--and I don't even know what to do about IPython.

An alternative would be to fallback to a different back end rather than ending anything and everything with an exception--at least in the case of trying to use the "default" backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0