8000 fix(react): allow using `enabled` when using `useQuery().promise` by arvi18 · Pull Request #7 · coderabbit-test/query · GitHub
[go: up one dir, main page]
Skip to content

fix(react): allow using enabled when using useQuery().promise #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

fix(react): allow using enabled when using useQuery().promise #7

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3b569b4
chore: add test for switching enabled state
KATT Jan 4, 2025
7bf0f38
remove sleep
KATT Jan 4, 2025
e01497a
mkay
KATT Jan 4, 2025
1455669
lint
KATT Jan 4, 2025
2ad266e
ci: apply automated fixes
autofix-ci[bot] Jan 4, 2025
b7cf7fc
wip
KATT Jan 6, 2025
b222b14
wip
KATT Jan 6, 2025
a7994c2
ci: apply automated fixes
autofix-ci[bot] Jan 6, 2025
f1daa83
meep
KATT Jan 6, 2025
a269d27
cool
KATT Jan 6, 2025
3445626
Merge branch 'issues/8499' of github.com:KATT/react-query into issues…
KATT Jan 6, 2025
7669e03
tweak
KATT Jan 6, 2025
46b7e06
eeek
KATT Jan 6, 2025
2f69183
Merge branch 'main' into issues/8499
KATT Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
meep
  • Loading branch information
@KATT
KATT committed Jan 6, 2025
commit f1daa83c2edf93647e7cbf538f74860f3f7a0b71
2 changes: 1 addition & 1 deletion packages/react-query/src/useBaseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ export function useBaseQuery<
!isServer &&
willFetch(result, isRestoring)
) {
// This fetching in the render should likely be done as part of the getOptimisticResult() considering https://github.com/TanStack/query/issues/8507
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Issue: The condition for shouldFetch has been modified to check cache entry state, but the comment "This fetching in the render should likely be done as part of the getOptimisticResult() considering TanStack#8507" suggests this may be a temporary solution. Consider addressing this architectural improvement in a future PR to ensure proper separation of concerns and better maintainability.

const cacheEntryState = cacheEntry?.state

const shouldFetch =
Expand All @@ -162,7 +163,6 @@ export function useBaseQuery<
cacheEntryState.status === 'pending' &&
cacheEntryState.fetchStatus === 'idle')

console.log({ shouldFetch })
const promise = shouldFetch
? // Fetch immediately on render in order to ensure `.promise` is resolved even if the component is unmounted
fetchOptimistic(defaultedOptions, observer, errorResetBoundary)
Expand Down
0