8000 fix(react): allow using `enabled` when using `useQuery().promise` by arvi18 · Pull Request #7 · coderabbit-test/query · GitHub
[go: up one dir, main page]

Skip to content

fix(react): allow using enabled when using useQuery().promise #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
wip
  • Loading branch information
KATT committed Jan 6, 2025
commit b222b14288dc2cfccb033730d462d30be372936e
71 changes: 71 additions & 0 deletions packages/react-query/src/__tests__/useQuery.promise.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1377,4 +1377,75 @@ describe('useQuery().promise', () => {
.observers.length,
).toBe(2)
})

it('should handle enabled state changes with suspense', async () => {
const key = queryKey()
const renderStream = createRenderStream({ snapshotDOM: true })
const queryFn = vi.fn(async () => {
await sleep(1)
return 'test'
})

function MyComponent(props: { enabled: boolean }) {
useTrackRenders()
const query = useQuery({
queryKey: key,
queryFn,
enabled: props.enabled,
staleTime: Infinity,
})

const data = React.use(query.promise)
return <>{data}</>
}

function Loading() {
useTrackRenders()
return <>loading..</>
}

function Page() {
useTrackRenders()
const enabledState = React.useState(false)
const enabled = enabledState[0]
const setEnabled = enabledState[1]

return (
<div>
<button onClick={() => setEnabled(true)}>enable</button>
<React.Suspense fallback={<Loading />}>
<MyComponent enabled={enabled} />
</React.Suspense>
</div>
)
}

const rendered = await renderStream.render(
<QueryClientProvider client={queryClient}>
<Page />
</QueryClientProvider>,
)

{
const result = await renderStream.takeRender()
result.withinDOM().getByText('loading..')
}

expect(queryFn).toHaveBeenCalledTimes(0)
rendered.getByText('enable').click()

{
const result = await renderStream.takeRender()
result.withinDOM().getByText('loading..')
}

expect(queryFn).toHaveBeenCalledTimes(1)

{
const result = await renderStream.takeRender()
result.withinDOM().getByText('test')
}

expect(queryFn).toHaveBeenCalledTimes(1)
})
})
0