fix: escape ampersand and question mark in ProxyCommand

Fixes #479.
coder · code-asher · Sep 13, 2024 · Sep 13, 2024 · Sep 13, 2024 · Sep 13, 2024
commit 565fd784a62099837457a1df6c7fd0338c02f235
diff --git a/src/main/kotlin/com/coder/gateway/util/Escape.kt b/src/main/kotlin/com/coder/gateway/util/Escape.kt
@@ -12,8 +12,10 @@ fun escape(s: String): String {
     if (s.contains("\n")) {
         throw Exception("argument cannot contain newlines")
     }
-    if (s.contains(" ") || s.contains("\t")) {
-        return "\"" + s.replace("\"", "\\\"") + "\""
+    if (s.contains(" ") || s.contains("\t") || s.contains("&") || s.contains("?")) {
+        // See https://github.com/coder/jetbrains-coder/issues/479
+        // Escape existing " and &
+        return "\"" + s.replace("\"", "\\\"").replace("&", "\\&").replace("?", "\\?") + "\""
     }
     return s.replace("\"", "\\\"")
 }