8000 fix: escape ampersand and question mark in ProxyCommand by kylecarbs · Pull Request #480 · coder/jetbrains-coder · GitHub
[go: up one dir, main page]
Skip to content

fix: escape ampersand and question mark in ProxyCommand #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 13, 2024
Merged

fix: escape ampersand and question mark in ProxyCommand #480

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
565fd78
fix: escape ampersand and question mark in ProxyCommand
kylecarbs Sep 13, 2024
209077c
Update platform version
code-asher Sep 13, 2024
ee23d22
Rely on quotes for escaping
code-asher Sep 13, 2024
57635e1
Add tests for escaping URLs
code-asher Sep 13, 2024
37c8797
Why did Intellij add this
code-asher Sep 13, 2024
f3e8264
Add changelog entry
code-asher Sep 13, 2024
2d7431c
Merge remote-tracking branch 'github/main' into escape
code-asher Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge remote-tracking branch 'github/main' into escape
  • Loading branch information
@code-asher
code-asher committed Sep 13, 2024
commit 2d7431c2ec4f249065fd5edbaa3af1df4cfd572f
9 changes: 6 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
994E
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

## Unreleased

### Fixed

- When a proxy command argument (such as the URL) contains `?` and `&`, escape
it in the SSH config by using double quotes, as these characters have special
meanings in shells.

## 2.14.0 - 2024-08-30

### Fixed
Expand All @@ -14,9 +20,6 @@
as "failed to retrieve IDEs". To aply this fix, you must add the connection
again through the "Connect to Coder" flow or by using the dashboard link (the
recent connections do not reconfigure SSH).
- When a proxy command argument (such as the URL) contains `?` and `&`, escape
it in the SSH config by using double quotes, as these characters have special
meanings in shells.

### Changed

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.
0