8000 refactor: Return template version name in the workspace build API by BrunoQuaresma · Pull Request #5178 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

refactor: Return template version name in the workspace build API #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 28, 2022
Merged

refactor: Return template version name in the workspace build API #5178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b002389
refactor: Return template version name in the workspace build API
BrunoQuaresma Nov 28, 2022
556aa05
Fix query verbiage
BrunoQuaresma Nov 28, 2022
65860d1
Fix database fake and entities
BrunoQuaresma Nov 28, 2022
2d4f72c
Fix workspaces.go
BrunoQuaresma Nov 28, 2022
3b41fd0
Fix template versions IDs loop
BrunoQuaresma Nov 28, 2022
1ecc0b8
return template versions even without resources
BrunoQuaresma Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix database fake and entities
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 28, 2022
commit 65860d169480086a5e7c9fd41670196170201ed7
20 changes: 20 additions & 0 deletions coderd/database/databasefake/databasefake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,6 +1666,26 @@ func (q *fakeQuerier) GetTemplateVersionByID(_ context.Context, templateVersionI
return database.TemplateVersion{}, sql.ErrNoRows
}

func (q *fakeQuerier) GetTemplateVersionsByIDs(_ context.Context, ids []uuid.UUID) ([]database.TemplateVersion, error) {
q.mutex.RLock()
defer q.mutex.RUnlock()

versions := make([]database.TemplateVersion, 0)
for _, version := range q.templateVersions {
for _, id := range ids {
if id == version.ID {
versions = append(versions, version)
break
}
}
}
if len(versions) == 0 {
return nil, sql.ErrNoRows
}

return versions, nil
}

func (q *fakeQuerier) GetTemplateVersionByJobID(_ context.Context, jobID uuid.UUID) (database.TemplateVersion, error) {
q.mutex.RLock()
defer q.mutex.RUnlock()
Expand Down
2 changes: 2 additions & 0 deletions site/src/testHelpers/entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ export const MockWorkspaceBuild: TypesGen.WorkspaceBuild = {
initiator_name: MockUser.username,
job: MockProvisionerJob,
template_version_id: MockTemplateVersion.id,
template_version_name: MockTemplateVersion.name,
transition: "start",
updated_at: "2022-05-17T17:39:01.382927298Z",
workspace_name: "test-workspace",
Expand All @@ -424,6 +425,7 @@ export const MockFailedWorkspaceBuild = (
initiator_name: MockUser.username,
job: MockFailedProvisionerJob,
template_version_id: MockTemplateVersion.id,
template_version_name: MockTemplateVersion.name,
transition: transition,
updated_at: "2022-05-17T17:39:01.382927298Z",
workspace_name: "test-workspace",
Expand Down
0