8000 refactor: Return template version name in the workspace build API by BrunoQuaresma · Pull Request #5178 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

refactor: Return template version name in the workspace build API #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 28, 2022
Merged

refactor: Return template version name in the workspace build API #5178

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b002389
refactor: Return template version name in the workspace build API
BrunoQuaresma Nov 28, 2022
556aa05
Fix query verbiage
BrunoQuaresma Nov 28, 2022
65860d1
Fix database fake and entities
BrunoQuaresma Nov 28, 2022
2d4f72c
Fix workspaces.go
BrunoQuaresma Nov 28, 2022
3b41fd0
Fix template versions IDs loop
BrunoQuaresma Nov 28, 2022
1ecc0b8
return template versions even without resources
BrunoQuaresma Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix workspaces.go
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 28, 2022
commit 2d4f72c602329addf8a734885e41051fbc94e5fc
2 changes: 2 additions & 0 deletions coderd/workspaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,7 @@ func (api *API) postWorkspacesByOrganization(rw http.ResponseWriter, r *http.Req
[]database.WorkspaceResourceMetadatum{},
[]database.WorkspaceAgent{},
[]database.WorkspaceApp{},
database.TemplateVersion{},
)
if err != nil {
httpapi.Write(ctx, rw, http.StatusInternalServerError, codersdk.Response{
Expand Down Expand Up @@ -930,6 +931,7 @@ func (api *API) workspaceData(ctx context.Context, workspaces []database.Workspa
data.metadata,
data.agents,
data.apps,
data.templateVersions,
)
if err != nil {
return workspaceData{}, xerrors.Errorf("convert workspace builds: %w", err)
Expand Down
0