8000 chore: update X11 forward session usage when there is a connection by spikecurtis · Pull Request #18567 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: update X11 forward session usage when there is a connection #18567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

chore: update X11 forward session usage when there is a connection #18567

merged 1 commit into from
Jun 27, 2025
+53 −8

Conversation

spikecurtis
Copy link
Contributor
@spikecurtis spikecurtis commented Jun 25, 2025 •
edited
Loading

fixes #18263

Adds support to bump usedAt for X11 forwarding sessions whenever an application connects over the TCP socket. This should help avoid evicting sessions that are actually in use.

This was referenced Jun 25, 2025
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author
spikecurtis commented Jun 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis mentioned this pull request Jun 25, 2025
Merged
@spikecurtis spikecurtis requested a review from mafredri June 25, 2025 10:32
@spikecurtis spikecurtis marked this pull request as ready for review June 25, 2025 10:33
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from bb744e8 to 971c5f1 Compare June 25, 2025 10:37
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch 2 times, most recently from 891b2ca to 69c6d73 Compare June 26, 2025 10:41
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 971c5f1 to 5ae64a6 Compare June 26, 2025 10:41
mafredri
mafredri approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member
@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍🍳

@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 5ae64a6 to 36e724a Compare June 27, 2025 09:42
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch 8000 2 times, most recently from b9c8109 to af561e0 Compare June 27, 2025 09:55
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 36e724a to 7ab52a2 Compare June 27, 2025 09:55
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch from af561e0 to fbebcbc Compare June 27, 2025 10:08
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 7ab52a2 to 752156b Compare June 27, 2025 10:08
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch from fbebcbc to 98d00a0 Compare June 27, 2025 10:26
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 752156b to d80d1c2 Compare June 27, 2025 10:26
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch from 98d00a0 to 862aeb8 Compare June 27, 2025 10:43
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from d80d1c2 to 94c9adb Compare June 27, 2025 10:44
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch from 862aeb8 to 3de717a Compare June 27, 2025 10:57
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 94c9adb to d74b343 Compare June 27, 2025 10:57
@spikecurtis spikecurtis force-pushed the spike/18263-test-used-ports branch 2 times, most recently from 5199273 to 4196627 Compare June 27, 2025 11:14
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from d74b343 to d1cc806 Compare June 27, 2025 11:14
@spikecurtis spikecurtis changed the base branch from spike/18263-test-used-ports to graphite-base/18567 June 27, 2025 11:27
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from d1cc806 to 0652761 Compare June 27, 2025 11:27
@spikecurtis spikecurtis force-pushed the graphite-base/18567 branch from 4196627 to 73c742a Compare June 27, 2025 11:27
@graphite-app graphite-app bot changed the base branch from graphite-base/18567 to main June 27, 2025 11:28
@spikecurtis spikecurtis force-pushed the spike/18263-x11-connection-update-usage branch from 0652761 to 7ae368d Compare June 27, 2025 11:28
@spikecurtis spikecurtis merged commit a02d5a6 into main Jun 27, 2025
34 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/18263-x11-connection-update-usage branch June 27, 2025 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Agent leaks SSH X11 Forwarding
2 participants
@spikecurtis @mafredri
0