8000 chore: refactor TestServer_X11 to use inproc networking by spikecurtis · Pull Request #18564 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: refactor TestServer_X11 to use inproc networking #18564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

chore: refactor TestServer_X11 to use inproc networking #18564

merged 1 commit into from
Jun 27, 2025

Conversation

spikecurtis
Copy link
Contributor
@spikecurtis spikecurtis commented Jun 25, 2025 •
edited
Loading

relates to #18263

Refactors the x11Forwarder to accept a networking interface that we can fake out for testing. This isolates the unit tests from other processes listening in the port range used by X11 forwarding. This will become extremely important in up-stack PRs where we listen on every port in the range and need to control which ports have conflicts.

8000 This was referenced Jun 25, 2025
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author
spikecurtis commented Jun 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jun 25, 2025
Merged
Merged
Merged
Merged
@spikecurtis spikecurtis requested a review from mafredri June 25, 2025 10:29
@spikecurtis spikecurtis marked this pull request as ready for review June 25, 2025 10:29
@spikecurtis spikecurtis force-pushed the spike/testutil-in-proc-net branch from 1e438a6 to b39371f Compare June 25, 2025 10:37
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from b60589d to 212e2a5 Compare June 25, 2025 10:37
mafredri
mafredri reviewed Jun 25, 2025
View reviewed changes
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from 212e2a5 to a272b09 Compare June 26, 2025 10:41
@spikecurtis spikecurtis force-pushed the spike/testutil-in-proc-net branch from b39371f to 319c17d Compare June 26, 2025 10:41
@spikecurtis spikecurtis requested a review from mafredri June 26, 2025 10:43
mafredri
mafredri approved these changes Jun 27, 2025
View reviewed changes
@spikecurtis spikecurtis force-pushed the spike/testutil-in-proc-net branch from 319c17d to 6dc4eab Compare June 27, 2025 09:42
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from a272b09 to e2d3899 Compare June 27, 2025 09:42
@spikecurtis spikecurtis force-pushed the spike/testutil-in-proc-net branch from 6dc4eab to bbc6b4c Compare June 27, 2025 10:06
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from e2d3899 to f3ebe91 Compare June 27, 2025 10:07
@spikecurtis spikecurtis force-pushed the spike/testutil-in-proc-net branch 2 times, most recently from 2665ffd to 32cfa80 Compare June 27, 2025 10:24
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from f3ebe91 to 449c022 Compare June 27, 2025 10:24
@spikecurtis spikecurtis changed the base branch from spike/testutil-in-proc-net to graphite-base/18564 June 27, 2025 10:42
@spikecurtis spikecurtis force-pushed the graphite-base/18564 branch from 32cfa80 to abcf3df Compare June 27, 2025 10:42
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from 449c022 to 702c154 Compare June 27, 2025 10:42
@graphite-app graphite-app bot changed the base branch from graphite-base/18564 to main June 27, 2025 10:43
@spikecurtis spikecurtis force-pushed the spike/18263-x11-network branch from 702c154 to 011e763 Compare June 27, 2025 10:43
@spikecurtis spikecurtis merged commit a5bfb20 into main Jun 27, 2025
35 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/18263-x11-network branch June 27, 2025 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @mafredri
0