fix: fix tests & linter

coder · evgeniy-scherbina · May 26, 2025 · May 22, 2025 · May 23, 2025 · May 23, 2025
commit 1b9593b3ae895012f1062fa1c801a4ea4b7fd59f
diff --git a/enterprise/coderd/prebuilds/metricscollector.go b/enterprise/coderd/prebuilds/metricscollector.go
@@ -280,6 +280,7 @@ func (k hardLimitedPresetKey) String() string {
 	return fmt.Sprintf("%s:%s:%s", k.orgName, k.templateName, k.presetName)
 }
 
+// nolint:revive // isHardLimited determines if the preset should be reported as hard-limited in Prometheus.
 func (mc *MetricsCollector) trackHardLimitedStatus(orgName, templateName, presetName string, isHardLimited bool) {
 	mc.isPresetHardLimitedMu.Lock()
 	defer mc.isPresetHardLimitedMu.Unlock()

diff --git a/enterprise/coderd/prebuilds/reconcile_test.go b/enterprise/coderd/prebuilds/reconcile_test.go
@@ -768,17 +768,15 @@ func TestSkippingHardLimitedPresets(t *testing.T) {
 				require.Equal(t, 2, len(workspaces))
 				require.Equal(t, database.PrebuildStatusHealthy, updatedPreset.PrebuildStatus)
 
-				// When hard limit is not reached, metric is set to 0.
+				// When hard limit is not reached, metric is not set.
 				mf, err = registry.Gather()
 				require.NoError(t, err)
 				metric = findMetric(mf, prebuilds.MetricPresetHardLimitedGauge, map[string]string{
 					"template_name": template.Name,
 					"preset_name":   preset.Name,
 					"org_name":      org.Name,
 				})
-				require.NotNil(t, metric)
-				require.NotNil(t, metric.GetGauge())
-				require.EqualValues(t, 0, metric.GetGauge().GetValue())
+				require.Nil(t, metric)
 				return
 			}