8000 feat: add hard-limited presets metric by evgeniy-scherbina · Pull Request #18008 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add hard-limited presets metric #18008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 26, 2025
Merged

feat: add hard-limited presets metric #18008

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6fb6800
feat: add hard-limited presets metric
evgeniy-scherbina May 22, 2025
a1a4f2a
fix: report metric only for active template version
evgeniy-scherbina May 23, 2025
2667684
fix: hard-limiting should only apply to creation of prebuilds
evgeniy-scherbina May 23, 2025
6a14a8b
test: improve test coverage for hard-limited presets
evgeniy-scherbina May 23, 2025
0882626
fix: make fmt
evgeniy-scherbina May 23, 2025
1c53074
refactor: improve documentation
evgeniy-scherbina May 23, 2025
3100e01
test: improve testing coverage
evgeniy-scherbina May 23, 2025
80c89fe
refactor: CR's fixes
evgeniy-scherbina May 26, 2025
1b9593b
fix: fix tests & linter
evgeniy-scherbina May 26, 2025
2a8e11b
Merge remote-tracking branch 'origin/main' into 17988-metric-for-hard…
evgeniy-scherbina May 26, 2025
00a2fcb
Update metric description
evgeniy-scherbina May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: make fmt
  • Loading branch information
@evgeniy-scherbina
evgeniy-scherbina committed May 23, 2025
commit 0882626f6d04fe11dc349ff37fa4a5b7a626027b
2 changes: 1 addition & 1 deletion enterprise/coderd/prebuilds/reconcile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ func TestHardLimitedPresetShouldNotBlockDeletion(t *testing.T) {
require.Equal(t, 1, jobStatusMap[database.ProvisionerJobStatusSucceeded])
require.Equal(t, 1, jobStatusMap[database.ProvisionerJobStatusFailed])

//Verify initial state: metric is not set - meaning preset is not hard limited.
// Verify initial state: metric is not set - meaning preset is not hard limited.
require.NoError(t, controller.ForceMetricsUpdate(ctx))
mf, err := registry.Gather()
require.NoError(t, err)
Expand Down
Loading
0