update versions

coder · Emyrk · May 12, 2025 · May 6, 2025 · May 7, 2025 · May 7, 2025
commit fd6cdf516b317e91b04955fff75864089fb6fb46
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -553,6 +553,8 @@ func (s *server) acquireProtoJob(ctx context.Context, job database.ProvisionerJo
 				WorkspaceID: workspaceBuild.WorkspaceID,
 				BuildNumber: buildNum,
 			})
+
+			// If the error is ErrNoRows, then assume previous values are empty.
 			if err != nil && !xerrors.Is(err, sql.ErrNoRows) {
 				return nil, xerrors.Errorf("get last build with number=%d: %w", buildNum, err)
 			}

diff --git a/codersdk/richparameters.go b/codersdk/richparameters.go
@@ -62,8 +62,8 @@ fun
8000
c validateBuildParameter(richParameter TemplateVersionParameter, buildParamet
 		return xerrors.Errorf("parameter value is required")
 	}
 
-	if value == "" { // parameter is optional, so take the default value
-		value = richParameter.DefaultValue
+	if current == "" { // parameter is optional, so take the default value
+		current = richParameter.DefaultValue
 	}
 
 	if len(richParameter.Options) > 0 {
@@ -101,13 +101,7 @@ func validateBuildParameter(richParameter TemplateVersionParameter, buildParamet
 		Error:       richParameter.ValidationError,
 		Monotonic:   string(richParameter.ValidationMonotonic),
 	}
-	var prev *string
-	// Empty strings should be rejected, however the previous behavior was to
-	// accept the empty string ("") as a `nil` previous value.
-	if lastBuildParameter != nil && lastBuildParameter.Value != "" {
-		prev = &lastBuildParameter.Value
-	}
-	return validation.Valid(richParameter.Type, value, prev)
+	return validation.Valid(richParameter.Type, current, previous)
 }
 
 func findBuildParameter(params []WorkspaceBuildParameter, parameterName string) (*WorkspaceBuildParameter, bool) {

@@ -12,9 +12,14 @@ import "github.com/coder/coder/v2/apiversion"
 //
 // API v1.4:
 //   - Add new field named `devcontainers` in the Agent.
+//
+// API v1.5:
+//   - Add previous parameter values to 'WorkspaceBuild' jobs. Provisioner passes
+//     the previous values for the `terraform apply` to enforce monotonicity
+//     in the terraform provider.
 const (
 	CurrentMajor = 1
-	CurrentMinor = 4
+	CurrentMinor = 5
 )
 
 // CurrentVersion is the current provisionerd API version.

diff --git a/tailnet/proto/version.go b/tailnet/proto/version.go
@@ -45,15 +45,9 @@ import (
 //     PushResourcesMonitoringUsage RPCs on the Agent API.
 //   - Added support for reporting connection events for auditing via the
 //     ReportConnection RPC on the Agent API.
-//
-// API v2.5:
-//   - Shipped in Coder v2.{{placeholder}} // TODO Steven: Replace with the correct version
-//   - Add previous parameter values to 'WorkspaceBuild' jobs. Provisioner passes
-//     the previous values for the `terraform apply` to enforce monotonicity
-//     in the terraform provider.
 const (
 	CurrentMajor = 2
-	CurrentMinor = 5
+	CurrentMinor = 4
 )
 
 var CurrentVersion = apiversion.New(CurrentMajor, CurrentMinor)