test: fix asserted test error text

coder · Emyrk · May 12, 2025 · May 6, 2025 · May 7, 2025 · May 7, 2025
commit 690daac01dafd86ef134a243a8afa172de421d5f
diff --git a/cli/update_test.go b/cli/update_test.go
@@ -757,7 +757,7 @@ func TestUpdateValidateRichParameters(t *testing.T) {
 			err := inv.Run()
 			// TODO: improve validation so we catch this problem before it reaches the server
 			// 		 but for now just validate that the server actually catches invalid monotonicity
-			assert.ErrorContains(t, err, fmt.Sprintf("parameter value must be equal or greater than previous value: %s", tempVal))
+			assert.ErrorContains(t, err, "parameter value '1' must be equal or greater than previous value: 2")
 		}()
 
 		matches := []string{

diff --git a/codersdk/richparameters.go b/codersdk/richparameters.go
@@ -70,7 +70,6 @@ func validateBuildParameter(richParameter TemplateVersionParameter, buildParamet
 		if !matched {
 			return xerrors.Errorf("parameter value must match one of options: %s", parameterValuesAsArray(richParameter.Options))
 		}
-		return nil
 	}
 
 	if !validationEnabled(richParameter) {