docs: change example styles to be single-attribute-per-line #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
|
@xvaara I played a bit with the prettier print-width & single-attribute-per-line settings and settled on just turning on the sing-attribute-per-line - I think that does a good job of addressing your concerns about readability of examples on phones without going too overboard and making things less readable on larger screens. Let me know if that works for you. |
VividLemon
approved these changes
Jun 9, 2025
xvaara
added a commit
to xvaara/bootstrap-vue-next
that referenced
this pull request
Jun 10, 2025
* upstream/main: docs: fix on-this-page for composable and directives pages (bootstrap-vue-next#2742) fix(BTableLite): field attribute isRowHeader now being respected (bootstrap-vue-next#2713) docs: change example styles to be single-attribute-per-line (bootstrap-vue-next#2731) fix(BTabs): Add type=button to buttons to prevent form submission (bootstrap-vue-next#2740) docs: fix unplugin-vue-components issue (bootstrap-vue-next#2724) fix(bforminput): abort debouncing if blur occurs chore: release main (bootstrap-vue-next#2735) fix(BTabs): correct id/index on ssr (bootstrap-vue-next#2726) Small fixes on 2025-06-06 (bootstrap-vue-next#2734) docs(BPopover): Parity pass (bootstrap-vue-next#2701) chore: release main Fix some tabs bugs, commit the previous pr override (bootstrap-vue-next#2720) chore: release main (bootstrap-vue-next#2698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Change the prettier settings for the examples to enforce single-attribute-per-line. This is generally more readable for examples. It also narrows most of the examples to make them more readable on small screens. I opted for not changing the print-width in prettier, since it didn't do a lot for the smaller screens and tended to make the example less readable on even medium sized-screens (like a laptop screen). But I can do that easily if we want to give it a shot.
Normally I have a high bar for formatting changes, but since I've already done a refactor on all of the affected examples, it doesn't affect who gets pointed to with git blame.
Small replication
Most of the examples in the docs that have been refactored into their own files. Fixes #2717
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied