8000 fix(BTableLite): field attribute isRowHeader now being respected by rgeerts · Pull Request #2713 · bootstrap-vue-next/bootstrap-vue-next · GitHub
[go: up one dir, main page]
Skip to content

fix(BTableLite): field attribute isRowHeader now being respected #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

fix(BTableLite): field attribute isRowHeader now being respected #2713

merged 3 commits into from
Jun 9, 2025

Conversation

rgeerts
Copy link
Contributor
@rgeerts rgeerts commented May 27, 2025 •
edited by coderabbitai bot
Loading

Describe the PR

According to documentation at https://bootstrap-vue-next.github.io/bootstrap-vue-next/docs/components/table.html#field-definition-reference
and to keep inline with the original "bootstrap-vue" implementation. The "isRowHeader" should a allow a td to be a th for if the field definition indicates a true value.

Small replication

See below that the "first_name" field should be a th instead of a td for all the rows.

<template>
  <div>
    <BTable striped hover :items="items" :fields="fields" />
  </div>
</template>

<script setup lang="ts">
const fields = [{key:'first_name', isRowHeader: true}, 'last_name', 'age']
const items = [
  {isActive: true, age: 40, first_name: 'Dickerson', last_name: 'Macdonald'},
  {isActive: false, age: 21, first_name: 'Larsen', last_name: 'Shaw'},
  {isActive: false, age: 89, first_name: 'Geneva', last_name: 'Wilson'},
  {isActive: true, age: 38, first_name: 'Jami', last_name: 'Carney'},
]
</script>

PR checklist

What kind of change does this PR introduce? (check at least one)

  • [x ] Bugfix 🐛 - fix(...)
  • Feature - feat(...)
  • ARIA accessibility - fix(...)
  • Documentation update - docs(...)
  • Other (please describe)

The PR fulfills these requirements:

  • [ x] Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

Summary by CodeRabbit

  • New Features
    • Table cells now dynamically render as header or data cells based on field properties, enhancing table accessibility and customization.
  • Tests
    • Added tests to ensure correct rendering of table cells as header or data cells according to field settings.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 27, 2025 •
edited
Loading

Walkthrough

The rendering logic for table body cells in the BTableLite component was updated to dynamically choose between header (BTh) and data (BTd) cell components based on a field property. A helper function was introduced for this purpose. Corresponding tests were added to verify correct rendering behavior depending on the isRowHeader property.

Changes

File(s) Change Summary
packages/bootstrap-vue-next/src/components/BTable/BTableLite.vue Added getCellComponent function; updated template to render cells as BTh or BTd dynamically.
packages/bootstrap-vue-next/src/components/BTable/table-lite.spec.ts Added test suite to verify cell rendering based on isRowHeader property.

Sequence Diagram(s)

sequenceDiagram
    participant Parent as Parent Component
    participant BTableLite as BTableLite
    participant getCellComponent as getCellComponent
    participant CellComponent as BTh/BTd

    Parent->>BTableLite: Render with fields and items
    loop For each field in row
        BTableLite->>getCellComponent: Determine cell component (BTh or BTd)
        getCellComponent-->>BTableLite: Return BTh if isRowHeader, else BTd
        BTableLite->>CellComponent: Render cell using selected component
    end
Loading

Suggested reviewers

  • VividLemon

Poem

In rows of tables, fields align,
Some are headers—others, just fine.
With clever code, the cells now know
If they should stand tall or lay low.
Tests confirm what bunnies see:
Table logic, bug-free as can be!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7847fd and 938cad1.

📒 Files selected for processing (1)
  • packages/bootstrap-vue-next/src/components/BTable/table-lite.spec.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/bootstrap-vue-next/src/components/BTable/table-lite.spec.ts
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: test-lint
  • GitHub Check: test-unit
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented May 27, 2025 •
edited
Loading

bsvn-vite-ts

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2713

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2713

commit: 938cad1

VividLemon
VividLemon requested changes Jun 2, 2025
View reviewed changes
@VividLemon VividLemon merged commit 9a4b648 into bootstrap-vue-next:main Jun 9, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Jun 9, 2025
Open
xvaara added a commit to xvaara/bootstrap-vue-next that referenced this pull request Jun 10, 2025
@xvaara
Merge remote-tracking branch 'upstream/main'
757f949 
* upstream/main:
  docs: fix on-this-page for composable and directives pages (bootstrap-vue-next#2742)
  fix(BTableLite): field attribute isRowHeader now being respected (bootstrap-vue-next#2713)
  docs: change example styles to be single-attribute-per-line (bootstrap-vue-next#2731)
  fix(BTabs): Add type=button to buttons to prevent form submission (bootstrap-vue-next#2740)
  docs: fix unplugin-vue-components issue (bootstrap-vue-next#2724)
  fix(bforminput): abort debouncing if blur occurs
  chore: release main (bootstrap-vue-next#2735)
  fix(BTabs): correct id/index on ssr (bootstrap-vue-next#2726)
  Small fixes on 2025-06-06 (bootstrap-vue-next#2734)
  docs(BPopover): Parity pass (bootstrap-vue-next#2701)
  chore: release main
  Fix some tabs bugs, commit the previous pr override (bootstrap-vue-next#2720)
  chore: release main (bootstrap-vue-next#2698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VividLemon VividLemon VividLemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgeerts @VividLemon
0